Skip to content

[rb] fix Ruby tests failing because of alerts in Firefox #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asolntsev merged 9 commits into from
Apr 3, 2026
Merged

[rb] fix Ruby tests failing because of alerts in Firefox #17294

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
671dd9b
fix Ruby tests failing because of alerts in Firefox
asolntsev Apr 2, 2026
20cc318
Try to fix symlink issue for rules_ruby
cgoldberg Apr 2, 2026
4054efe
Trigger CI manually
cgoldberg Apr 2, 2026
0046c7b
Merge branch 'trunk' into fix/failing-ruby-tests
cgoldberg Apr 2, 2026
75df0cd
Fix workflow syntax
cgoldberg Apr 2, 2026
6fe4230
Try again fixing the symlink issue
cgoldberg Apr 2, 2026
c6f22db
Revert workaround for ruby symlink issue
cgoldberg Apr 2, 2026
7ae9d7a
Merge branch 'trunk' into fix/failing-ruby-tests
cgoldberg Apr 3, 2026
a8f89c0
Merge branch 'trunk' into fix/failing-ruby-tests
asolntsev Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/bazel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,13 @@ jobs:
crates: rust/Cargo.Bazel.lock
repository-cache: true
bazelrc: common --color=yes
# Workaround for rules_ruby MSYS2 "infinite symlink expansion detected" on Windows
- name: Remove MSYS2 recursive symlink
if: inputs.os == 'windows'
shell: bash
run: |
[ -L "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" ] && \
rm "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-"
- name: Setup curl for Ubuntu
if: inputs.os == 'ubuntu'
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev
Expand Down
1 change: 1 addition & 0 deletions rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ def firefox_options(args: [], **opts)
opts[:browser_version] = 'stable' if WebDriver::Platform.windows?
opts[:web_socket_url] = true if ENV['WEBDRIVER_BIDI'] && !opts.key?(:web_socket_url)
opts[:binary] ||= rlocation(ENV['FIREFOX_BINARY']) if ENV.key?('FIREFOX_BINARY')
opts[:unhandled_prompt_behavior] ||= 'ignore'
args << '--headless' if ENV['HEADLESS']
WebDriver::Options.firefox(args: args, **opts)
end
Expand Down