Skip to content

[rust] Fix Windows arm64 logic for Selenium Manager and prepare CI for running the test suite #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennisameling wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

[rust] Fix Windows arm64 logic for Selenium Manager and prepare CI for running the test suite #16046

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fd1c063
[rust] Fix Windows arm64 logic for Selenium Manager and prepare CI
dennisameling Jul 12, 2025
029e59e
Add build and release logic (MSVC supports cross-compilation)
dennisameling Jul 28, 2025
3ddf340
Merge branch 'trunk' into selenium-manager-windows-arm64
cgoldberg Jul 28, 2025
560650b
bazel.yml: fix Windows detection logic to also work on windows-11-arm
dennisameling Jul 28, 2025
825f5db
Merge branch 'trunk' into selenium-manager-windows-arm64
cgoldberg Jul 28, 2025
212f8af
Fix merge conflicts and update bazel workflow
cgoldberg Dec 29, 2025
c5e8084
Fix CI build on windows-11-arm
dennisameling Feb 2, 2026
f7e53c3
Merge remote-tracking branch 'upstream/trunk' into selenium-manager-w…
dennisameling Feb 2, 2026
2dd11e7
Merge branch 'trunk' into selenium-manager-windows-arm64
cgoldberg Feb 2, 2026
00e0646
Merge branch 'trunk' into selenium-manager-windows-arm64
cgoldberg Feb 3, 2026
d55474f
Merge branch 'trunk' into selenium-manager-windows-arm64
cgoldberg Feb 3, 2026
d64c64d
Merge remote-tracking branch 'upstream/trunk' into selenium-manager-w…
dennisameling Mar 13, 2026
3da14db
Ensure Windows arm64 builds and tests correctly
dennisameling Mar 13, 2026
b02ef7b
Fix Firefox download
dennisameling Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
- os: macos
- os: ubuntu
- os: windows
- os: windows-11-arm
Comment thread
cgoldberg marked this conversation as resolved.
with:
name: Tests (${{ matrix.os }})
cache-key: rust-test
Expand Down
2 changes: 1 addition & 1 deletion rust/src/electron.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ impl SeleniumManager for ElectronManager {
if X32.is(arch) {
"win32-ia32"
} else if ARM64.is(arch) {
"win32-arm64-x64"
"win32-arm64"
} else {
"win32-x64"
}
Expand Down
2 changes: 1 addition & 1 deletion rust/src/firefox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ impl SeleniumManager for FirefoxManager {
if X32.is(arch) || major_browser_version < 42 {
platform_label = "win32";
} else if ARM64.is(arch) {
platform_label = "win-aarch64";
platform_label = "win64-aarch64";
} else {
platform_label = "win64";
}
Expand Down