Document LLVM 22 intrinsic signature changes in upgrade-llvm skill#82
Merged
Merged
Conversation
The LLVM 22 upgrade hit a codegen bug the build could not catch: the llvm.lifetime intrinsics dropped their size argument, and ponyc's two-argument emission only failed at module verification, surfaced by the test suite. Capture that pattern, plus the -Werror/attribute distinction that determines which deprecated C-APIs actually force a change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by the LLVM 22.1.6 upgrade in ponylang/ponyc#5364.
The
llvm.lifetime.start/llvm.lifetime.endintrinsics dropped their size argument in LLVM 22. ponyc's two-argument emission compiled clean but failed at module verification, caught only by the full-program tests, not the build. Adds an "Intrinsic signature changes" section capturing that class of migration and the fact that it won't show up at build time.Also clarifies the deprecated-variants section: under
-Werror, only C-APIs carryingLLVM_ATTRIBUTE_C_DEPRECATEDforce a change. In 22.1.6 that was justLLVMGetMDKindID; the array/string variants are doc-comment deprecated only, so the list shouldn't be migrated wholesale.