Skip to content

Security: WebSocket Room Access Control#2937

Closed
ghost wants to merge 76 commits into
mainfrom
unknown repository
Closed

Security: WebSocket Room Access Control#2937
ghost wants to merge 76 commits into
mainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 2, 2026

Summary

This PR hardens the WebSocket subscription logic by restricting clients to a predefined set of public rooms.

Changes

  1. Room Whitelisting: Implemented an whitelist in the event handler. This prevents clients from subscribing to arbitrary room names, which could be used to intercept internal messages or probe for private event channels.
  2. Input Normalization: Added string normalization and stripping for room identifiers.
  3. Error Reporting: Added explicit error emission for unauthorized room requests.

Closes #2295

Michael Sovereign added 30 commits April 12, 2026 16:30
feat: implement RIP-309 Phase 1 Fingerprint Check Rotation
9005379
fix: address Codex review for RIP-309 Phase 1
1c1e41c
fix: complete RIP-309 integration with reward gating and signature fix
d4ad46b
fix: integrate canonical RIP-309 rotation module for reward weighting
4d2b086
fix: bind _handle_get_state signature to msg_id and ttl (arity fix #2288
d5c825d 
)
Security: Hardened P2P sync with replay protection, nonces, and deter…
2080a24 
…ministic JSON
Security: Prevent mining reward type confusion in mempool and UTXO apply
464a08e
Security: Hardened Server Proxy with path whitelisting and header for…
ba859a7 
…warding
Security: Atomic balance checks and secure hash generation for Bridge…
a84314c 
… API
Security: Fix voting precision by migrating from REAL to INTEGER weights
ed6d1e9
Enhancement: Added environment variable support and API authenticatio…
2437488 
…n for auto-settler
Security: Implemented cryptographic authentication for bounty claims …
574c26b 
…and contract updates
Enhancement: Added address validation and security checks for x402 co…
2aef619 
…nfiguration
Security: Fixed potential SQL injection in passport listing
cc7b765
Security: Protected Hall of Rust from SQL injection and data vandalism
9e59f39
Security: Hardened LLM JSON extraction in Sophia Governor
1239068
Security: Switched to full SHA-256 for machine identity to prevent co…
92a73c9 
…llisions
Security: Added robustness to cache feature extraction to prevent cra…
4851646 
…shes on empty data
Security: Switched from float to Decimal for precise financial calcul…
29c6686 
…ations in payouts
Security: Switched from print to logging and improved error handling …
ee06e4e 
…in claims eligibility
Security: Enforced commitment matching in BCOS attestation to prevent…
dfbfa93 
… report tampering
Security: Added database-level CHECK constraints for transaction amou…
1b134b4 
…nts to prevent negative value injection
Security: Hardened claim ID generation to prevent potential ID collis…
179a811 
…ions
Security: Prevented field-level DoS in hardware binding by capping MA…
11e7c32 
…C address and flag storage
Security: Implemented HMAC authentication for P2P state and attestati…
a0cee05 
…on endpoints to prevent data leakage
Security: Implemented atomic transactions for IP rate limiting to pre…
88cac3f 
…vent race condition bypass
Security: Implemented input sanitization to prevent prompt injection …
a6ec6e6 
…in Sophia Inspector
Enhancement: Added environment variable support and timeout protectio…
2d532ae 
…n for Ergo anchoring
Security: Prevented Sybil attacks in Warthog rewards by enforcing uni…
140f85d 
…que WART addresses per epoch
Security: Enforced global uniqueness for GitHub accounts and wallets …
631c761 
…in airdrop to prevent double-claiming
MichaelSovereign added 21 commits May 2, 2026 06:51
Security: Implemented atomic transactions for fingerprint rate limiti…
f334222 
…ng to prevent TOCTOU bypass
Security: Prevented Link Injection and Phishing by disabling untruste…
fb68e6e 
…d X-Forwarded-Host header in feed builders
Security: Implemented score clamping and total re-calculation in BCOS…
bfb8abb 
… PDF generator to prevent misleading certificates
Enhancement: Added exponential backoff retry logic to payout worker f…
e3856c8 
…or improved reliability
Security: Implemented input sanitization and type enforcement for Web…
b77099e 
…Socket broadcasts in Elya Service
Security: Hardened oEmbed video ID extraction and prevented Host Inje…
e98bbc0 
…ction in embed routes
Security: Prevented authentication bypass in lock ledger when admin k…
726f2b1 
…ey is unconfigured
Security: Implemented permission validation for pinned TLS certificat…
17d02da 
…es to prevent MitM via certificate tampering
Bugfix: Fixed broken XML syntax in Atom feed thumbnail generation
4c4946a
Security: Switched to Decimal for precise balance conversion during U…
4b64929 
…TXO genesis migration
Security: Switched to Decimal for precise financial calculations in U…
cc48400 
…TXO transfer endpoint
Security: Hardened WebSocket configuration by restricting CORS and re…
e4c8bfc 
…ducing max buffer size
Security: Hardened withdrawal archive storage with directory isolatio…
7dbd8bc 
…n and strict file permissions
Security: Implemented strict public key validation for epoch enrollme…
9a355d2 
…nt to prevent identity spoofing
Security: Improved Merkle hash calculation efficiency and implemented…
c11ef71 
… row limits to prevent DoS
Security: Implemented automatic mempool cleanup to prevent resource e…
2d11c1f 
…xhaustion from expired transactions
Enhancement: Standardized error responses in Elya Service for better …
7155bd9 
…integration with block explorer
Security: Hardened wallet hopping detection with stricter thresholds …
d0976db 
…and extended history analysis
Security: Enforced admin authentication for UTXO statistics endpoint …
05e04ed 
…to prevent information disclosure
Enhancement: Added server time collection to consensus probe for impr…
f907498 
…oved synchronization diagnostics
Security: Implemented room name validation for WebSocket subscription…
14dc456 
…s to prevent unauthorized channel access
@ghost ghost requested a review from Scottcjn as a code owner May 2, 2026 06:01
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) consensus Consensus/RIP-200 related node Node server related tests Test suite changes size/XL PR: 500+ lines labels May 2, 2026
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented May 3, 2026

Closing as part of Tier 0 hard-ban cleanup — see #3074 / #3104 / #3169 for the documented incident chain. All MichaelSovereign PRs are closed unread per the Tier 0 contract. No review path; no future PRs from this account will be processed. (See feedback_michaelsovereign_tier0_2026-05-02.md.)

@Scottcjn Scottcjn closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scottcjn Scottcjn Awaiting requested review from Scottcjn Scottcjn is a code owner

Assignees

No one assigned

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) consensus Consensus/RIP-200 related node Node server related size/XL PR: 500+ lines tests Test suite changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Scottcjn