docs: fix incorrect rustchain.org URLs in CONTRIBUTING.md#2781
Closed
wuxiaobinsh-gif wants to merge 14 commits into
Closed
docs: fix incorrect rustchain.org URLs in CONTRIBUTING.md#2781wuxiaobinsh-gif wants to merge 14 commits into
wuxiaobinsh-gif wants to merge 14 commits into
Conversation
Fixes TypeError when STATE requested by providing msg_id and ttl arguments to _signed_content(). The function signature requires 5 args since PR Scottcjn#2274 but _handle_get_state was calling with 3. Changes: - Generate msg_id via sha256 hash for state response - Pass ttl=0 for state responses - Include msg_id and ttl in response dict for requester verification Fixes Scottcjn#2288
Owner
|
@wuxiaobinsh-gif — thanks for the breadth of fixes. Reviewing the 14 commits in this PR, I count at least 6 different bounties bundled together:
Per our one-bounty-per-PR rule, this is too much in one PR — and several pieces compete with your own other open PRs (#2670, #2671, #2691). The merge queue can't pick a winner cleanly. Action: I'm closing this PR. Please reopen each fix as its own focused PR. We'll pay each one individually — that's actually MORE total RTC than bundling, not less. Looking at your current open PRs, please:
When you've split, ping me here and I'll prioritize review. |
This was referenced Apr 29, 2026
Contributor
Claim Submission — Star + File Bug Report (1 RTC)What I did:
The bug report documents two real issues in
Both issues include reproduction steps and suggested fixes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect
rustchain.orgURLs inCONTRIBUTING.mdto point to the actual live node at50.28.86.131.Changes
https://rustchain.org/healthtohttps://50.28.86.131/healthhttps://50.28.86.131instead ofhttps://rustchain.orgrustchain.orgto50.28.86.131Testing
Verified the correct endpoint works:
curl -sk https://50.28.86.131/health # Returns: {"ok":true,"version":"2.2.1-rip200",...}Fixes #2783