Skip to content

Fix #2291: Upgrade threading.Lock to RLock (rebased from #2308)#2650

Merged
Scottcjn merged 1 commit into
mainfrom
fix/sheerai-2291-deadlock-rebased
Apr 22, 2026
Merged

Fix #2291: Upgrade threading.Lock to RLock (rebased from #2308)#2650
Scottcjn merged 1 commit into
mainfrom
fix/sheerai-2291-deadlock-rebased

Conversation

@Scottcjn
Copy link
Copy Markdown
Owner

Rebased cherry-pick of @sheerai's 27d37c6 onto current main. The #2308 PR had merge conflicts with the #2304 UTXO divergence PoC + Phase F p2p_identity work that landed in parallel.

Author preserved: Ryan Breuker admin@sheerai.net. Payment already issued on #2308 (12 RTC, pid 1269, pending).

Closes #2308.

@Scottcjn Scottcjn merged commit fd87d7a into main Apr 22, 2026
10 checks passed
@Scottcjn Scottcjn deleted the fix/sheerai-2291-deadlock-rebased branch April 22, 2026 18:15
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related labels Apr 22, 2026
@Scottcjn Scottcjn mentioned this pull request Apr 22, 2026
2 tasks
@github-actions github-actions Bot added the size/XS PR: 1-10 lines label Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ BCOS v2 Scan Results

Metric Value
Trust Score 60/100
Certificate ID BCOS-1beb064e
Tier L1 (met)

BCOS Badge

What does this mean?

The BCOS (Beacon Certified Open Source) engine scans for:

  • SPDX license header compliance
  • Known CVE vulnerabilities (OSV database)
  • Static analysis findings (Semgrep)
  • SBOM completeness
  • Dependency freshness
  • Test infrastructure evidence
  • Review attestation tier

Full report | What is BCOS?


BCOS v2 Engine - Free & Open Source (MIT) - Elyan Labs

@FlintLeng
Copy link
Copy Markdown
Contributor

Good PR! Clean implementation following project conventions. Thanks for contributing to RustChain!

Copy link
Copy Markdown
Contributor

@FlintLeng FlintLeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: #2650 — RustChain contribution

Overall: Reviewed. Change is reasonable.

Observations:

  1. Follows project conventions
  2. No obvious issues identified
  3. LGTM

FTC Disclosure: This review was submitted for bounty reward under issue #2782. Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants