Skip to content

[#2288] Fix _handle_get_state arity mismatch #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

[#2288] Fix _handle_get_state arity mismatch #2323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions node/rustchain_p2p_gossip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def _verify_signature(self, content: str, signature: str, timestamp: int) -> boo
mode = self._signing_mode

from p2p_identity import unpack_signature, verify_ed25519
hmac_sig, ed25519_sig = unpack_signature(signature)
hmac_sig, ed25519_sig, _v = unpack_signature(signature)

# "strict" mode: only Ed25519 accepted. HMAC-only sigs are rejected
# even if valid (flag-day enforcement).
Expand Down Expand Up @@ -480,7 +480,7 @@ def verify_message(self, msg: GossipMessage) -> bool:
mode = self._signing_mode

from p2p_identity import unpack_signature, verify_ed25519
hmac_sig, ed25519_sig = unpack_signature(msg.signature)
hmac_sig, ed25519_sig, _v = unpack_signature(msg.signature)

# 1) Try Ed25519 if available AND peer is registered.
if ed25519_sig and self._peer_registry is not None:
Expand Down Expand Up @@ -880,16 +880,22 @@ def _handle_get_state(self, msg: GossipMessage) -> Dict:
"balances": self.balance_crdt.to_dict()
}
# Sign the state response so the requester can verify authenticity.
# Uses the Phase A signed-content shape (msg_type:sender_id:payload)
# so verify_message() on the requester side accepts it.
# SECURITY (#2272): must include msg_id and ttl for arity compliance.
payload = {"state": state_data}
content = self._signed_content(MessageType.STATE.value, self.node_id, payload)

# Generate synthetic msg_id for the response (non-forwarded, ttl=0)
import hashlib, time
state_msg_id = hashlib.sha256(f"STATE:{self.node_id}:{time.time()}".encode()).hexdigest()[:24]

content = self._signed_content(MessageType.STATE.value, self.node_id, state_msg_id, 0, payload)
signature, timestamp = self._sign_message(content)
return {
"status": "ok",
"state": state_data,
"signature": signature,
"timestamp": timestamp,
"msg_id": state_msg_id,
"ttl": 0,
"sender_id": self.node_id
}

Expand Down
Loading