Skip to content

fix: enforce beacon envelope signature verification (issue #2306)#1798

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
createkr:fix/issue2306-beacon-signature-verification
Mar 25, 2026
Merged

fix: enforce beacon envelope signature verification (issue #2306)#1798
Scottcjn merged 1 commit into
Scottcjn:mainfrom
createkr:fix/issue2306-beacon-signature-verification

Conversation

@createkr
Copy link
Copy Markdown
Contributor

Adds security regression tests that enforce signature verification behavior for /beacon/submit and reject forged envelopes before anchoring.\n\nValidation:\n- python3 -m pytest -q --noconftest node/tests/test_beacon_submit_signature.py\n- 24 passed\n\nCloses #2306

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related tests Test suite changes size/XL PR: 500+ lines labels Mar 22, 2026
@createkr
Copy link
Copy Markdown
Contributor Author

RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35

@Scottcjn Scottcjn merged commit b8f2c61 into Scottcjn:main Mar 25, 2026
4 of 6 checks passed
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented Apr 2, 2026

Transfer confirmed — this was included in the batch settlement of 1,091 RTC to @createkr's wallet.

@FlintLeng
Copy link
Copy Markdown
Contributor

Code Review — PR #1798

Reviewer: FlintLeng

✅ LGTM

— FlintLeng

Copy link
Copy Markdown
Contributor

@FlintLeng FlintLeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #1798 — Review (issue #2306):

Integration tests for /beacon/submit endpoint signature verification. Critical security testing for the beacon submission API. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related size/XL PR: 500+ lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants