LocalPreferences Namespace nesting - #77
Open
lukaskollmer wants to merge 2 commits into
Open
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PSchmiedmayer
approved these changes
Aug 30, 2026
PSchmiedmayer
left a comment
Contributor
There was a problem hiding this comment.
Thanks @lukaskollmer 🚀
Comment on lines
+379
to
+380
| /// - Note: Bulk-removing a namespace (via ``LocalPreferencesStore/removeAllEntries(in:)`` | ||
| /// will also remove all entries belonging to nested namespaces within the outer one. |
Contributor
There was a problem hiding this comment.
To be a bit clearer?
Suggested change
| /// - Note: Bulk-removing a namespace (via ``LocalPreferencesStore/removeAllEntries(in:)`` | |
| /// will also remove all entries belonging to nested namespaces within the outer one. | |
| /// - Note: Bulk-removing a outer namespace (via ``LocalPreferencesStore/removeAllEntries(in:)`` | |
| /// will also remove all entries belonging to nested namespaces within the parent namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
the
LocalPreferencesAPI in GroveFoundation currently does not support nested key namespaces.we consider this a desirable feature, as it will allow fine-grained control over bulk deletion of specific groups of items within a larger parent group.
for example, an app will typically wish to place all of its entries into an app-wide namespace. but if, within that, it has a collection of entries that belong to the same "thing", and it wishes to be able to delete them all at once, that currently is not possible. it'd have to delete all of the entries in its app-wide namespace, which would end up affecting random other things.
⚙️ Release Notes
LocalPreferenceKeys. note that bulk-clearing a namespace will also remove any entries belonging to namespaces nested w/in the namespace being bulk-cleared📚 Documentation
yes
✅ Testing
yes
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: