Skip to content

housekeeping - #21

Merged
lukaskollmer merged 9 commits into
mainfrom
lukas/housekeeping
Jul 14, 2026
Merged

housekeeping#21
lukaskollmer merged 9 commits into
mainfrom
lukas/housekeeping

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

♻️ Current situation & Problem

@PSchmiedmayer had a stab at various package-wide improvements and fixes in #17, such as addressing warnings, deprecations, etc. this work also partly overlaps with some things addressed in #5 (which probably will end up getting superseded by this PR).
this PR picks up these adjustments (which initially were developed against #16), and carries them over into the current #20-based main branch state of the codebase.

somewhat complete list of changes:

⚙️ Release Notes

todo

📚 Documentation

todo

✅ Testing

todo

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer self-assigned this Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 183 files, which is 33 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9cac9d2f-e32d-40e7-aadc-0828b7c8d82a

📥 Commits

Reviewing files that changed from the base of the PR and between d55dd3a and b28c2cd.

⛔ Files ignored due to path filters (6)
  • Sources/Spezi/Spezi.docc/Resources/AccountSetup.png is excluded by !**/*.png
  • Sources/Spezi/Spezi.docc/Resources/ChatView.png is excluded by !**/*.png
  • Sources/Spezi/Spezi.docc/Resources/Consent1.png is excluded by !**/*.png
  • Sources/Spezi/Spezi.docc/Resources/PairedDevices.png is excluded by !**/*.png
  • Sources/Spezi/Spezi.docc/Resources/QuestionnaireOverview.png is excluded by !**/*.png
  • Sources/Spezi/Spezi.docc/Resources/Validation.png is excluded by !**/*.png
📒 Files selected for processing (183)
  • .github/workflows/static-analysis.yml
  • .github/workflows/tests.yml
  • .spi.yml
  • .swiftlint.yml
  • Package.swift
  • REUSE.toml
  • Scripts/affected-test-matrix.py
  • Scripts/build-documentation.sh
  • Scripts/cleanup-generated-artifacts.sh
  • Scripts/run-package-tests.sh
  • Sources/ByteCodingTesting/ByteCodingTesting.docc/ByteCodingTesting.md
  • Sources/Codegen/Codegen.swift
  • Sources/FHIRModelsExtensions/CONTRIBUTORS.md
  • Sources/FHIRModelsExtensions/FHIR Extension Builder/FHIRExtensionBuilder+AbsoluteTimeRange.swift
  • Sources/FHIRModelsExtensions/Questionnaire+Extensions+UI.swift
  • Sources/HealthKitOnFHIR/CONTRIBUTORS.md
  • Sources/HealthKitOnFHIR/HKSampleMapping/HKStateOfMindSampleMapping.swift
  • Sources/HealthKitOnFHIR/HealthKit Extensions/HKCategoryValue+Coding.swift
  • Sources/HealthKitOnFHIR/HealthKit Extensions/HKElectrocardiogram+Observation.swift
  • Sources/HealthKitOnFHIR/HealthKit Extensions/HKSample+ResourceProxy.swift
  • Sources/HealthKitOnFHIR/HealthKitOnFHIR.docc/HealthKitOnFHIR.md
  • Sources/LocalizationsProcessor/LocalizationsProcessor.swift
  • Sources/ResearchKitOnFHIR/CONTRIBUTORS.md
  • Sources/RuntimeAssertions/CONTRIBUTORS.md
  • Sources/RuntimeAssertionsTesting/RuntimeAssertionsTesting.docc/RuntimeAssertionsTesting.md
  • Sources/Spezi/CONTRIBUTORS.md
  • Sources/Spezi/Spezi.docc/Initial Setup.md
  • Sources/Spezi/Spezi.docc/Interactions with Application.md
  • Sources/Spezi/Spezi.docc/Resources/AccountSetup.png.license
  • Sources/Spezi/Spezi.docc/Resources/ChatView.png.license
  • Sources/Spezi/Spezi.docc/Resources/Consent1.png.license
  • Sources/Spezi/Spezi.docc/Resources/PairedDevices.png.license
  • Sources/Spezi/Spezi.docc/Resources/QuestionnaireOverview.png.license
  • Sources/Spezi/Spezi.docc/Resources/Validation.png.license
  • Sources/Spezi/Spezi.docc/Spezi.md
  • Sources/Spezi/Spezi/Spezi.swift
  • Sources/Spezi/Spezi/SpeziPropertyWrapper.swift
  • Sources/SpeziAccessGuard/AccessGuards.swift
  • Sources/SpeziAccessGuard/CONTRIBUTORS.md
  • Sources/SpeziAccount/AccountOverview.swift
  • Sources/SpeziAccount/CONTRIBUTORS.md
  • Sources/SpeziAccount/Mock/InMemoryAccountService.swift
  • Sources/SpeziAccount/Mock/InMemoryAccountStorageProvider.swift
  • Sources/SpeziAccount/SpeziAccount.docc/AccountKey/Adding new Account Values.md
  • Sources/SpeziAccount/SpeziAccount.docc/Setup Guides/Initial Setup.md
  • Sources/SpeziAccount/ViewModifier/RequiredValidationModifier.swift
  • Sources/SpeziAccount/Views/AccountSetup/AccountSetupState.swift
  • Sources/SpeziAccount/Views/DataEntry/GeneralizedDataEntryView.swift
  • Sources/SpeziAccount/Views/PasswordResetView.swift
  • Sources/SpeziAccountPhoneNumbers/DataEntry/OTCEntryView.swift
  • Sources/SpeziAccountPhoneNumbers/PhoneVerificationConstraint.swift
  • Sources/SpeziAccountPhoneNumbers/SpeziAccountPhoneNumbers.docc/SpeziAccountPhoneNumbers.md
  • Sources/SpeziBluetooth/AccessorySetupKit/ASAccessoryEventType+Description.swift
  • Sources/SpeziBluetooth/AccessorySetupKit/AccessoryEventRegistration.swift
  • Sources/SpeziBluetooth/AccessorySetupKit/AccessorySetupKit.swift
  • Sources/SpeziBluetooth/CONTRIBUTORS.md
  • Sources/SpeziBluetooth/CoreBluetooth/BluetoothManager.swift
  • Sources/SpeziBluetooth/CoreBluetooth/BluetoothPeripheral.swift
  • Sources/SpeziBluetooth/CoreBluetooth/Model/BluetoothManagerStorage.swift
  • Sources/SpeziBluetooth/CoreBluetooth/Model/CharacteristicAccesses.swift
  • Sources/SpeziBluetooth/CoreBluetooth/Utilities/BluetoothWorkItem.swift
  • Sources/SpeziBluetooth/CoreBluetooth/Utilities/SpeziBluetoothActor.swift
  • Sources/SpeziChat/CONTRIBUTORS.md
  • Sources/SpeziChat/MessageInputView.swift
  • Sources/SpeziConsent/CONTRIBUTORS.md
  • Sources/SpeziConsent/Model/ConsentDocument+ExportConfiguration.swift
  • Sources/SpeziConsent/Model/ConsentDocument.swift
  • Sources/SpeziContact/CONTRIBUTORS.md
  • Sources/SpeziContact/Contact Views/ContactView.swift
  • Sources/SpeziContact/Contact Views/ContactsList.swift
  • Sources/SpeziContact/Models/ContactOption.swift
  • Sources/SpeziDevices/CONTRIBUTORS.md
  • Sources/SpeziDevices/Model/PairedDeviceInfo.swift
  • Sources/SpeziDevices/PairedDevices.swift
  • Sources/SpeziDevices/SpeziDevices.docc/HealthKit Integration.md
  • Sources/SpeziDevices/SpeziDevices.docc/SpeziDevices.md
  • Sources/SpeziDevices/Testing/MockDevice.swift
  • Sources/SpeziFHIR/CONTRIBUTORS.md
  • Sources/SpeziFHIR/FHIRResource/FHIRResource+StringifyAttachment.swift
  • Sources/SpeziFHIR/FHIRResource/FHIRResource.swift
  • Sources/SpeziFHIR/FHIRStore.swift
  • Sources/SpeziFHIRHealthKit/FHIRStore+HealthKit.swift
  • Sources/SpeziFileFormats/CONTRIBUTORS.md
  • Sources/SpeziFirebase/CONTRIBUTORS.md
  • Sources/SpeziFirestore/SpeziFirestore.docc/SpeziFirestore.md
  • Sources/SpeziFoundation/CONTRIBUTORS.md
  • Sources/SpeziFoundation/LocalPreferences/LocalPreference.swift
  • Sources/SpeziFoundation/Misc/Version.swift
  • Sources/SpeziHealthKit/CONTRIBUTORS.md
  • Sources/SpeziHealthKit/Health Data Collection/HealthDataCollector.swift
  • Sources/SpeziHealthKit/HealthKit Extensions/HKHealthStore+BackgroundDelivery.swift
  • Sources/SpeziHealthKit/HealthKit Extensions/Sleep Sessions/SleepSession.swift
  • Sources/SpeziHealthKit/HealthKit.swift
  • Sources/SpeziHealthKit/Queries/HealthKitStatisticsQuery.swift
  • Sources/SpeziHealthKit/Sample Types/AnySampleType.swift
  • Sources/SpeziHealthKit/Sample Types/SampleTypeDefs.py
  • Sources/SpeziHealthKit/Sample Types/SampleTypeProxy+Initializers.swift
  • Sources/SpeziHealthKit/Sample Types/SampleTypeProxy.swift
  • Sources/SpeziHealthKit/Sample Types/SampleTypes.swift
  • Sources/SpeziHealthKit/Sample Types/SampleTypes.swift.gyb
  • Sources/SpeziHealthKitBulkExport/BulkExportSession.swift
  • Sources/SpeziHealthKitBulkExport/SpeziHealthKitBulkExport.docc/BulkHealthExporter.md
  • Sources/SpeziKeychainStorage/Credentials/Credentials.swift
  • Sources/SpeziKeychainStorage/KeychainStorage.swift
  • Sources/SpeziLLM/CONTRIBUTORS.md
  • Sources/SpeziLicense/CONTRIBUTORS.md
  • Sources/SpeziLicense/Views/ContributionsList.swift
  • Sources/SpeziLocalStorage/LocalStorage.swift
  • Sources/SpeziLocalStorage/LocalStorageKey.swift
  • Sources/SpeziLocalStorage/SpeziLocalStorage.docc/SpeziLocalStorage.md
  • Sources/SpeziLocation/CONTRIBUTORS.md
  • Sources/SpeziNetworking/CONTRIBUTORS.md
  • Sources/SpeziNotifications/CONTRIBUTORS.md
  • Sources/SpeziNumerics/MedFloatImpl.swift
  • Sources/SpeziOnboarding/CONTRIBUTORS.md
  • Sources/SpeziPersonalInfo/Fields/NameFieldRow.swift
  • Sources/SpeziQuestionnaire/CONTRIBUTORS.md
  • Sources/SpeziScheduler/CONTRIBUTORS.md
  • Sources/SpeziScheduler/Scheduler.swift
  • Sources/SpeziScheduler/SpeziScheduler.docc/SpeziScheduler.md
  • Sources/SpeziScheduler/Task/Outcome.swift
  • Sources/SpeziScheduler/Task/Task.swift
  • Sources/SpeziScheduler/UserInfo/UserStorageCoding.swift
  • Sources/SpeziSensorKit/CONTRIBUTORS.md
  • Sources/SpeziSensorKit/Sensor Reader/AnchoredFetcher+TimeIntervalFetching.swift
  • Sources/SpeziSensorKit/Sensor Reader/AnchoredFetcher.swift
  • Sources/SpeziSensorKit/SensorKit.swift
  • Sources/SpeziSensorKit/SpeziSensorKit.docc/SpeziSensorKit.md
  • Sources/SpeziSpeech/CONTRIBUTORS.md
  • Sources/SpeziStorage/CONTRIBUTORS.md
  • Sources/SpeziStudy/CONTRIBUTORS.md
  • Sources/SpeziStudy/Study Manager/StudyManager+Other.swift
  • Sources/SpeziStudy/Study Manager/StudyManager.swift
  • Sources/SpeziStudyDefinition/StudyBundle/StudyBundle+FileReference.swift
  • Sources/SpeziStudyDefinition/StudyBundle/StudyBundle.swift
  • Sources/SpeziStudyDefinition/StudyBundle/Validation/StudyBundle+QuestionnaireValidation.swift
  • Sources/SpeziStudyDefinition/StudyDefinition.swift
  • Sources/SpeziValidation/Views/VerifiableTextField.swift
  • Sources/SpeziViews/CONTRIBUTORS.md
  • Sources/SpeziViews/SpeziViews.docc/SpeziViews.md
  • Sources/SpeziViews/Views/Button/AsyncButton.swift
  • Sources/SpeziViews/Views/Drawing/CanvasView.swift
  • Sources/SpeziViews/Views/Sharing/ShareSheetInput.swift
  • Sources/SpeziViews/Views/Text/MarkdownView+ImageProviders.swift
  • Sources/SpeziViews/Views/Text/MarkdownView.swift
  • Sources/ThreadLocal/CONTRIBUTORS.md
  • Sources/XCTHealthKit/CONTRIBUTORS.md
  • Sources/XCTHealthKit/XCTHealthKitAddSampleInput.swift
  • Sources/XCTHealthKit/XCTest+HealthRecord.swift
  • Sources/XCTRuntimeAssertions/XCTRuntimeAssertions.docc/XCTRuntimeAssertions.md
  • Sources/XCTSpeziAccount/XCTSpeziAccount.docc/XCTSpeziAccount.md
  • Sources/XCTSpeziAccount/XCUIApplication+AccountValues.swift
  • Sources/XCTSpeziNotifications/XCTSpeziNotifications.docc/XCTSpeziNotifications.md
  • Sources/XCTestExtensions/CONTRIBUTORS.md
  • Tests/ByteCodingTests/ByteCodableTests.swift
  • Tests/HealthKitOnFHIRTests/TimeZoneTests.swift
  • Tests/SpeziAccessGuardTests/SpeziAccessGuardTests.swift
  • Tests/SpeziFHIRTests/FHIRAttachment/TextContentExtractorTests.swift
  • Tests/SpeziFoundationTests/AnyAsyncSequenceTests.swift
  • Tests/SpeziFoundationTests/RWLockTests.swift
  • Tests/SpeziHealthKitTests/HKUnitTests.swift
  • Tests/SpeziHealthKitTests/SampleTypesTests.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+Array.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+CustomTypes.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+Dictionary.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+Enum.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+InvalidParameters.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests+OptionalTypes.swift
  • Tests/SpeziLLMTests/LLMOpenAIFunctionCallingParameterDSLTests.swift
  • Tests/SpeziLLMTests/OpenAIInferenceTests/LLMOpenAIMockedInferenceTests+Setup.swift
  • Tests/SpeziNotificationsTests/SpeziNotificationTests.swift
  • Tests/SpeziSchedulerTests/ScheduleTests.swift
  • Tests/SpeziSchedulerTests/SchedulerTests.swift
  • Tests/SpeziSchedulerTests/Utils/ExampleTaskKey.swift
  • Tests/SpeziSchedulerUITests/SchedulerSampleDataTests.swift
  • Tests/SpeziStorageTests/LocalStorageTests.swift
  • Tests/SpeziStudyTests/StudyDefinitionTests.swift
  • Tests/SpeziTests/CapabilityTests/NotificationsTests.swift
  • Tests/SpeziTests/ModuleTests/ModuleTests.swift
  • Tests/SpeziViewsTests/UITests/TestApp/ViewsTests/ButtonTestView.swift
  • Tests/SpeziViewsTests/UITests/TestApp/ViewsTests/SpeziViewsTests.swift
  • Tests/SpeziViewsTests/UITests/TestAppUITests/SpeziViews/ViewsTests.swift
  • packages.toml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukaskollmer lukaskollmer added the enhancement New feature or request label Jul 13, 2026
@lukaskollmer
lukaskollmer marked this pull request as ready for review July 13, 2026 17:50

@PSchmiedmayer PSchmiedmayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work here; looks great! Happy to see this merged once the CI Is all running 🚀

@lukaskollmer
lukaskollmer merged commit 24735f1 into main Jul 14, 2026
321 of 328 checks passed
@lukaskollmer
lukaskollmer deleted the lukas/housekeeping branch July 14, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants