tutorial whisper#3760
Conversation
EtienneM
left a comment
There was a problem hiding this comment.
issue: I feel like this tutorial lacks a lot of link to external documentation and Scalingo documentation.
|
Thanks for the suggestion, I have updated the tutorial |
EtienneM
left a comment
There was a problem hiding this comment.
LGTM, I won't approve before the repository is under Scalingo organization
|
Thanks, I will also wait for @Frzk review too |
Frzk
left a comment
There was a problem hiding this comment.
- The main issue that prevents me to approve is the URL of the code repo - so nothing really blocking :)
- I've made a bunch of suggestions and nitpicks that, IMHO, would improve the style of the tuto and make it a bit more "qualitative" and homogeneous with the existing ones.
- I've also added an idea, for later :P
Nice project, I hope people will enjoy it and build nice things from it 😃
|
Thanks for the comments, I also made a PR here : Scalingo/scalingo-labs#2 |
Frzk
left a comment
There was a problem hiding this comment.
A few styling issues, else will be good for me once the repo is there :)
Frzk
left a comment
There was a problem hiding this comment.
LGTM, please wait for everything to be in place before merging :)
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
This PR add the speech to text tutorial, here the repo for the code:
https://github.com/SC-Samir/whisper-scalingo