refactor: replace Combine WebSocket streams with AsyncStream - #16
Open
Sandesh282 wants to merge 4 commits into
Open
Sandesh282 wants to merge 4 commits into
Sandesh282 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous WebSocket layer used Combine
PassthroughSubject/CurrentValueSubjectto propagate live events fromLiveWebSocketServiceup through the repository and ViewModel layers. This created a mixed-concurrency model where Swift Concurrency (actor,async/await) owned all state, but Combine owned all event propagation — forcing callers to bridge between the two worlds with.sink+Task { }wrappers that are easy to get wrong.This PR removes that split entirely. The entire event path is now 100% pure Swift Concurrency.
Changes
WebSocketService.swift— Protocolevents: AnyPublisher<WebSocketEvent, Never>→eventStream: AsyncStream<WebSocketEvent>connectionState: AnyPublisher<...>→connectionStateStream: AsyncStream<WebSocketConnectionState>WebSocketEventandWebSocketConnectionStatenow conform toSendableso they can safely cross actor boundaries inside continuationsLiveWebSocketService.swift— Concrete ImplementationPassthroughSubject/CurrentValueSubject[UUID: Continuation]dictionary pattern guarded byNSLock— each call toeventStreamreturns an independentAsyncStreambacked by its own continuation, so multiple concurrent subscribers (e.g.ContestRepository+SubmissionRepository) don't interfere with each otherconnectionStateStreamyields the current state immediately on subscription (cold observable equivalent ofCurrentValueSubject)Repositories —
ProfileRepository,ContestRepository,SubmissionRepositoryimport CombinebindWebSocketEvents()Combine.sinkclosures withwithTaskGroup+for await event in wsService.eventStreamloops.throttle(for:scheduler:latest:)AsyncStreamproperties (e.g.ratingUpdated,verdictReceived) backed by the same continuation dictionary patternViewModels —
ContestViewModel,ProfileViewModelimport CombineSet<AnyCancellable>+.sink/.assignwith[Task<Void, Never>]observation tasksMainActor.run { }explicitly, making the threading contract visible in codeBefore / After
AnyPublisher(Combine)AsyncStream(Swift Concurrency).sink+store(in:)for awaitloop inTask.receive(on: DispatchQueue.main)await MainActor.run { }Testing
Build-verified on Xcode (simulator). No functional behaviour changes — this is a pure infrastructure refactor. Existing SwiftUI previews and app flow unchanged.