Skip to content

feat: enable Nullable<T> inspection for complex types (Guid?, DateTime?, etc.) #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GustavEikaas wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

feat: enable Nullable<T> inspection for complex types (Guid?, DateTime?, etc.) #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/debugger/evaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,22 @@ static HRESULT InternalWalkMembers(EvalHelpers *pEvalHelpers, ICorDebugValue *pI
if (className == "decimal") // TODO: implement mechanism for walking over custom type fields
return S_OK;

if (className.back() == '?') // System.Nullable<T>, don't provide class member list.
if (className.back() == '?') // System.Nullable<T>
{
ToRelease<ICorDebugValue> pValueValue;
ToRelease<ICorDebugValue> pHasValueValue;
IfFailRet(GetNullableValue(pInputValue, &pValueValue, &pHasValueValue));

BYTE hasValueByte = 0;
ToRelease<ICorDebugGenericValue> pGenericValue;
IfFailRet(pHasValueValue->QueryInterface(IID_ICorDebugGenericValue, (LPVOID*)&pGenericValue));
IfFailRet(pGenericValue->GetValue((LPVOID)&hasValueByte));

if (hasValueByte != 0)
return InternalWalkMembers(pEvalHelpers, pValueValue, pThread, frameLevel, nullptr, provideSetterData, cb);

return S_OK;
}

CorElementType corElemType;
IfFailRet(pType->GetType(&corElemType));
Expand Down