Skip to content

[TCSACR-661][Tizen.Uix.InputMethod] Remove deprecated RotationChanged event#7743

Open
Inhong wants to merge 1 commit into
Samsung:mainfrom
Inhong:remove_deprecated_api
Open

[TCSACR-661][Tizen.Uix.InputMethod] Remove deprecated RotationChanged event#7743
Inhong wants to merge 1 commit into
Samsung:mainfrom
Inhong:remove_deprecated_api

Conversation

@Inhong

@Inhong Inhong commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description of Change

[Tizen.Uix.InputMethod] Remove deprecated RotationChanged event

API Changes

@Inhong Inhong requested a review from imfine98 as a code owner July 7, 2026 10:03
@github-actions github-actions Bot added the API15 label Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated rotation-related events, delegates, and classes from the Tizen.Uix.InputMethod namespace, including the RotationChanged event, RotationChangedEventArgs class, and their associated interop bindings. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@TizenAPI-Bot

Copy link
Copy Markdown
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 3, Changed: 0

Removed

- /// <since_tizen>4</since_tizen
- [Obsolete]
- System.EventHandler`1<Tizen.Uix.InputMethod.RotationChangedEventArgs> Tizen.Uix.InputMethod.InputMethodEditor::RotationChanged

- /// <since_tizen>4</since_tizen
- [Obsolete]
- Tizen.Uix.InputMethod.RotationChangedEventArgs

- /// <since_tizen>4</since_tizen
- [Obsolete]
- System.Int32 Tizen.Uix.InputMethod.RotationChangedEventArgs::Degree()

@Inhong Inhong added API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0 and removed API15 labels Jul 7, 2026
@JoonghyunCho

Copy link
Copy Markdown
Member

🤖 [AI Review]

Reviewed — no findings.

Scope checked:

  • Verified all 3 removed symbols are deleted together as a consistent set: the RotationChanged event plus its backing field and ImeRotationChangedCb delegate field in InputMethodEditor.cs, the RotationChangedEventArgs class, and the ImeEventSetRotationChangedCb P/Invoke + ImeRotationChangedCb delegate in Interop.InputMethod.cs.
  • Grepped the full repo (src/, test/, internals/, tools/) for remaining references to RotationChanged, RotationChangedEventArgs, ImeRotationChangedCb, and ime_event_set_rotation_degree_changed_cb — none remain outside the 3 touched files, so no dangling-reference build risk.
  • Confirmed deprecation policy compliance: every removed member was marked Obsolete with 'Deprecated since API12. Will be removed in API14.', and this removal targets API14 with ACR TCSACR-661 linked.
  • Deletion-only diff — neighboring DisplayLanguageChanged / AccessibilityStateChanged handlers and the rest of the public API surface are untouched.

No 🔴 critical issues, no 🟡 suggestions to flag.


Automated review — final merge decision rests with human reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACR Required API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants