Skip to content

[AI Task] [Tizen.Sensor] Cache Marshal.SizeOf in Sensor batch event hot path #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoonghyunCho wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AI Task] [Tizen.Sensor] Cache Marshal.SizeOf in Sensor batch event hot path #7739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055ff86
Refactor: Cache Marshal.SizeOf in Sensor batch event hot path (Fixes …
Jul 5, 2026
7e2b6c0
Address review feedback
Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Tizen.Sensor/Tizen.Sensor/Sensor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public abstract class Sensor : IDisposable
private SensorPausePolicy _pausePolicy = SensorPausePolicy.None;
private IntPtr _sensorHandle = IntPtr.Zero;
private IntPtr _listenerHandle = IntPtr.Zero;
private static readonly int s_sensorEventStructSize = Marshal.SizeOf<Interop.SensorEventStruct>();
internal IList<Interop.SensorEventStruct> BatchedEvents { get; set; } = new List<Interop.SensorEventStruct>();


Expand Down Expand Up @@ -93,7 +94,7 @@ internal void updateBatchEvents(IntPtr eventsPtr, uint events_count)
for (int i = 0; i < events_count; i++)
{
BatchedEvents.Add(Interop.IntPtrToEventStruct(currentPtr));
currentPtr += Marshal.SizeOf<Interop.SensorEventStruct>();
currentPtr += s_sensorEventStructSize;
}
Comment on lines 99 to 103

@gemini-code-assist gemini-code-assist Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since updateBatchEvents is on a hot path and BatchedEvents is cleared and repopulated on every call, we can optimize memory allocations by ensuring the underlying List<T> has sufficient capacity before the loop. This avoids multiple internal array reallocations and copying overhead during the loop.

Since BatchedEvents is initialized as a List<Interop.SensorEventStruct>, we can cast it and set its Capacity if it is currently smaller than events_count.

                if (BatchedEvents is List<Interop.SensorEventStruct> list && list.Capacity < events_count)
                {
                    list.Capacity = (int)events_count;
                }

                for (int i = 0; i < events_count; i++)
                {
                    BatchedEvents.Add(Interop.IntPtrToEventStruct(currentPtr));
                    currentPtr += s_sensorEventStructSize;
                }

}
}
Expand Down
Loading