[Security.PrivacyPrivilegeManager] CheckPermissionsAsync(), RequestPermissionsAsync() by wiertel · Pull Request #7732 · Samsung/TizenFX

wiertel · 2026-07-03T10:27:43Z

Description of Change

A replacement for deprecated privilege requesting API.

API Changes

ACR: TCSACR-657

    public static class Tizen.Security.PrivacyPrivilegeManager
    {
        static Task<PermissionResult> CheckPermissionsAsync(IEnumerable<string> privileges)
        static Task<PermissionResult> RequestPermissionsAsync(IEnumerable<string> required = null, IEnumerable<string> optional = null)
        static Task<IEnumerable<string>> LoadPrivilegesFromManifestAsync()
    }

…rmissionsAsync()

gemini-code-assist · 2026-07-03T10:30:55Z

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

TizenAPI-Bot · 2026-07-03T10:32:55Z

Public API Changed

Please follow the ACR process for the changed API below.

Added: 21, Removed: 0, Changed: 1

Added

+ /// <since_tizen>14</since_tizen
+ Tizen.Security.PermissionDeniedException

+ /// <since_tizen>14</since_tizen
+ System.Collections.Generic.IEnumerable`1<System.String> Tizen.Security.PermissionDeniedException::DeniedPrivileges()

+ /// <since_tizen>14</since_tizen
+ System.Void Tizen.Security.PermissionDeniedException::.ctor(System.Collections.Generic.IDictionary`2<System.String,Tizen.Security.PermissionStatus>)

+ /// <since_tizen>14</since_tizen
+ Tizen.Security.PermissionStatus Tizen.Security.PermissionDeniedException::GetStatus(System.String)

+ /// <since_tizen>14</since_tizen
+ Tizen.Security.PermissionResult

+ /// <since_tizen>14</since_tizen
+ System.Boolean Tizen.Security.PermissionResult::AreAllGranted()

+ /// <since_tizen>14</since_tizen
+ System.Boolean Tizen.Security.PermissionResult::IsGranted(System.String)

+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.Security.PermissionResult::.ctor()

+ /// <since_tizen>14</since_tizen
+ Tizen.Security.PermissionStateExtensions

+ /// <since_tizen>14</since_tizen
+ static System.Boolean Tizen.Security.PermissionStateExtensions::IsGranted(Tizen.Security.PermissionStatus)

+ /// <since_tizen>14</since_tizen
+ Tizen.Security.PermissionStatus

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::Ask

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::Deferred

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::Denied

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::DeniedSession

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::Granted

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::GrantedInUse

+ /// <since_tizen>none</since_tizen
+ static Tizen.Security.PermissionStatus Tizen.Security.PermissionStatus::GrantedSession

+ /// <since_tizen>14</since_tizen
+ static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<System.String>> Tizen.Security.PrivacyPrivilegeManager::LoadPrivilegesFromManifestAsync()

+ /// <since_tizen>14</since_tizen
+ static System.Threading.Tasks.Task`1<Tizen.Security.PermissionResult> Tizen.Security.PrivacyPrivilegeManager::CheckPermissionsAsync(System.Collections.Generic.IEnumerable`1<System.String>)

+ /// <since_tizen>14</since_tizen
+ static System.Threading.Tasks.Task`1<Tizen.Security.PermissionResult> Tizen.Security.PrivacyPrivilegeManager::RequestPermissionsAsync(System.Collections.Generic.IEnumerable`1<System.String>,System.Collections.Generic.IEnumerable`1<System.String>)

Changed

/// <since_tizen>4</since_tizen
- [Obsolete]
Tizen.Security.PrivacyPrivilegeManager

JoonghyunCho · 2026-07-05T23:08:48Z

+            var requiredList = required != null ? new List<string>(required) : new List<string>();
+
+            // Remove from required any privileges that are also in optional (they become optional)
+            var actualRequired = requiredList.Where(p => !optionalSet.Contains(p)).ToList();


🤖 [AI Review]
🔴 Critical: If required contains duplicate entries, a denied privilege appears twice in actualRequired and the ToDictionary call below throws ArgumentException (duplicate key) instead of the documented PermissionDeniedException.

Suggested change

var actualRequired = requiredList.Where(p => !optionalSet.Contains(p)).ToList();

var actualRequired = requiredList.Where(p => !optionalSet.Contains(p)).Distinct().ToList();

JoonghyunCho · 2026-07-05T23:08:58Z

+        /// List<string> manifestPrivileges = await PrivacyPrivilegeManager.LoadPrivilegesFromManifestAsync();
+        /// PermissionResult states = await PrivacyPrivilegeManager.CheckPermissionsAsync(manifestPrivileges);
+        /// bool allGranted = states.AllGranted();


🤖 [AI Review]
🟡 Suggestion: This example doesn't compile — LoadPrivilegesFromManifestAsync returns Task<IEnumerable<string>> (not assignable to List<string>), and the method on PermissionResult is AreAllGranted(), not AllGranted(). The example on LoadPrivilegesFromManifestAsync has the same List<string> issue.

Suggested change

/// List<string> manifestPrivileges = await PrivacyPrivilegeManager.LoadPrivilegesFromManifestAsync();

/// PermissionResult states = await PrivacyPrivilegeManager.CheckPermissionsAsync(manifestPrivileges);

/// bool allGranted = states.AllGranted();

/// IEnumerable<string> manifestPrivileges = await PrivacyPrivilegeManager.LoadPrivilegesFromManifestAsync();

/// PermissionResult states = await PrivacyPrivilegeManager.CheckPermissionsAsync(manifestPrivileges);

/// bool allGranted = states.AreAllGranted();

JoonghyunCho · 2026-07-05T23:09:05Z

+    /// bool isGranted = permissions.IsGranted("http://tizen.org/privilege/account.read");
+    ///
+    /// // Check if all privileges are granted
+    /// bool allGranted = permissions.AllGranted();


🤖 [AI Review]
🟡 Suggestion: AllGranted() doesn't exist on this class — the method declared below is AreAllGranted().

Suggested change

/// bool allGranted = permissions.AllGranted();

/// bool allGranted = permissions.AreAllGranted();

JoonghyunCho · 2026-07-05T23:09:13Z

+    /// <summary>
+    /// Extension methods for PermissionState.
+    /// </summary>
+    /// <since_tizen> 14 </since_tizen>
+    public static class PermissionStateExtensions


🤖 [AI Review]
🟡 Suggestion: This new public class is named after a PermissionState type that doesn't exist — the enum it extends is PermissionStatus, and the name becomes permanent public API once approved.

Suggested change

/// <summary>

/// Extension methods for PermissionState.

/// </summary>

/// <since_tizen> 14 </since_tizen>

public static class PermissionStateExtensions

/// <summary>

/// Extension methods for PermissionStatus.

/// </summary>

/// <since_tizen> 14 </since_tizen>

public static class PermissionStatusExtensions

JoonghyunCho · 2026-07-05T23:09:21Z

+        public PermissionDeniedException(IDictionary<string, PermissionStatus> denied)
+            : base("Required permissions denied: " + string.Join(", ", denied.Keys))


🤖 [AI Review]
🟡 Suggestion: denied is dereferenced in the base-constructor call, so a null argument surfaces as NullReferenceException; throw ArgumentNullException explicitly for the new public API.

Suggested change

public PermissionDeniedException(IDictionary<string, PermissionStatus> denied)

: base("Required permissions denied: " + string.Join(", ", denied.Keys))

public PermissionDeniedException(IDictionary<string, PermissionStatus> denied)

: base("Required permissions denied: " + string.Join(", ", (denied ?? throw new ArgumentNullException(nameof(denied))).Keys))

JoonghyunCho · 2026-07-05T23:09:29Z

🤖 [AI Review]
Left 5 inline comments (🔴 1, 🟡 4). See inline for details.

Automated review by AI assistant

[Security.PrivacyPrivilegeManager] CheckPermissionsAsync(), RequestPe…

962b297

…rmissionsAsync()

wiertel requested a review from terry2000s as a code owner July 3, 2026 10:27

github-actions Bot added the API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0 label Jul 3, 2026

TizenAPI-Bot added the ACR Required label Jul 3, 2026

JoonghyunCho reviewed Jul 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Security.PrivacyPrivilegeManager] CheckPermissionsAsync(), RequestPermissionsAsync()#7732

[Security.PrivacyPrivilegeManager] CheckPermissionsAsync(), RequestPermissionsAsync()#7732
wiertel wants to merge 1 commit into
Samsung:API14from
wiertel:new-ppm3

wiertel commented Jul 3, 2026

Uh oh!

gemini-code-assist Bot commented Jul 3, 2026

Uh oh!

TizenAPI-Bot commented Jul 3, 2026

Added

Changed

Uh oh!

JoonghyunCho Jul 5, 2026

Uh oh!

JoonghyunCho Jul 5, 2026

Uh oh!

JoonghyunCho Jul 5, 2026

Uh oh!

JoonghyunCho Jul 5, 2026

Uh oh!

JoonghyunCho Jul 5, 2026

Uh oh!

JoonghyunCho commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	var actualRequired = requiredList.Where(p => !optionalSet.Contains(p)).ToList();
	var actualRequired = requiredList.Where(p => !optionalSet.Contains(p)).Distinct().ToList();

	/// bool allGranted = permissions.AllGranted();
	/// bool allGranted = permissions.AreAllGranted();

		public PermissionDeniedException(IDictionary<string, PermissionStatus> denied)
		: base("Required permissions denied: " + string.Join(", ", denied.Keys))

Uh oh!

Conversation

wiertel commented Jul 3, 2026

Description of Change

API Changes

Uh oh!

gemini-code-assist Bot commented Jul 3, 2026

Uh oh!

TizenAPI-Bot commented Jul 3, 2026

Public API Changed

Added

Changed

Uh oh!

JoonghyunCho Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoonghyunCho Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoonghyunCho Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoonghyunCho Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoonghyunCho Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoonghyunCho commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants