Repository navigation
composer patch updates - #1480
Merged
Merged
Conversation
Contributor
Author
|
SPD is behind on maintenance. Needs dependabot rules to not upgrade symfony. It needs rector, SF 6.4 > 7.4 upgrade and JS package updates. |
johanib
force-pushed
the
feature/upgrade-jun
branch
from
June 2, 2026 08:26
663d1fa to
6bb8844
Compare
johanib
force-pushed
the
feature/upgrade-jun
branch
from
June 2, 2026 08:36
6bb8844 to
acbfa9d
Compare
Prior to this change, running the webtests relied on `docker compose up` in spdashboard. However, this caused the engine container to restart, messing with the mounted version via devconf. This change prevents spdashboard interfering with the running containers. Additionally, the webtests run in the `dev` environment. So relying on the `docker-compose-ci.yml` was confusing.
WebTestCase.php, In finishLogin(), replaced the immediate refreshCrawler() with waitFor('.page__title, .page-container').
This waits until either the EB consent page or the SP dashboard appears before running the consent-page check. This properly handles the case where click() in php-webdriver v1.16.0 no longer implicitly waits for navigation to complete.
This reverts commit e3e5045.
Contributor
Author
|
OpenConext/OpenConext-devconf#93 needs to merge before the pipeline can become green again. TODO: change back to devconf/main, after above PR has been merged, before merging this. |
johanib
force-pushed
the
feature/upgrade-jun
branch
from
June 2, 2026 12:08
313d2cc to
b52173d
Compare
Contributor
Author
|
Reviewed with Kay ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.