Skip to content

fix: let healthy swap orders survive oracle failures (RAI-3008) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findolor merged 4 commits into from
Oct 8, 2026
Merged

fix: let healthy swap orders survive oracle failures (RAI-3008) #197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c96d59f
fix: let healthy swap orders survive oracle failures (RAI-3008)
findolor Oct 8, 2026
092c901
fix: enforce mixed-book fill after SDK requoting
findolor Oct 8, 2026
db27309
ci: run all oracle integration regressions
findolor Oct 8, 2026
c5337be
fix: preserve invalid swap cap errors and share fill selection
findolor Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/src/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ provider failures in one error variant, so the API conservatively emits

`SWAP_ORACLE_UNAVAILABLE` does not assert that a market is closed. It means an
oracle-backed order could not be evaluated because its external context endpoint
was unavailable. Individual order reverts that are not identified as oracle
fetch failures are treated as non-executable liquidity; failures of the overall
quote operation remain `SWAP_QUOTE_FAILED`.
was unavailable and the surviving healthy orders could not fully serve the
request within its price limits. An unavailable order does not block an
otherwise complete healthy route. Individual order reverts that are not
identified as oracle fetch failures are treated as non-executable liquidity;
failures of the overall quote operation remain `SWAP_QUOTE_FAILED`.

Domain codes are assigned at the boundary where the failure is understood.
Detailed dependency logs and the coded response event share the same
Expand Down
12 changes: 9 additions & 3 deletions docs/src/swap-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,15 @@ and execution.
clients. Omitting `chainId` selects Base (`8453`). Use V3 for any other network.

Oracle-backed orders can be temporarily unavailable for evaluation when their
external context fetch fails. Quote endpoints then return HTTP 503 with
`SWAP_ORACLE_UNAVAILABLE`. This is distinct from HTTP 404 `SWAP_NO_LIQUIDITY`,
which means the evaluated order set has no executable capacity for the request.
external context fetch fails. Such orders are excluded from the executable
route. Healthy orders can still serve quotes and calldata, including
slippage-based requests, when they fill the requested amount within the
applicable price limits. If unavailable orders leave the request without a
complete healthy route, the API returns HTTP 503 with `SWAP_ORACLE_UNAVAILABLE`,
including for up-to modes. Without oracle failures, up-to modes still allow
partial fills. This is distinct from HTTP 404 `SWAP_NO_LIQUIDITY`, which means
the evaluated order set has no executable capacity for the request. Selected
orders still require valid oracle context and calldata preflight checks.

### Understanding Price Limits

Expand Down
Loading
Loading