Feature/pisn ifmr - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple new IFMR prescriptions which were created in the exact same way as the original (updated-)SSE IFMRs were, but where the
psflagwas set to 1, which enables: "PPSN/PSN schemes according to Belczynski et al., 2016, A&A 594, A97".This means the IFMRs are identical, up to high masses where they become a constant value of ~40.5 Msun, and then drop to 0 entirely.
With the fixes introduced in #17, these should be handled fine now.
Note that I didn't also implement the fallback-fractions (though they are packaged here) simply because they are the exact same as the non-ppsn versions, and those should just be used instead.