-
Notifications
You must be signed in to change notification settings - Fork 60
Feature: Holm Security Devices #2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vg-svitla
wants to merge
3
commits into
develop
Choose a base branch
from
feature/holm_security_devices
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.0.0] - 2026-07-17 | ||
|
|
||
| ### Added | ||
|
|
||
| - Holm Security module with API token authentication | ||
| - Account validator | ||
| - Device asset connector that collects agent-managed devices from `GET /v2/devices` and maps them to the OCSF Device Inventory Info model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "name": "Holm Security Devices", | ||
| "description": "Fetch agent-managed devices enrolled in Holm Security as OCSF device assets", | ||
| "uuid": "4df342f5-9fb0-4d45-97c0-bdae48e2e7c2", | ||
| "docker_parameters": "holm_security_device_asset_connector", | ||
| "type": "asset", | ||
| "capability": "host_detection", | ||
| "arguments": { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "properties": { | ||
| "sekoia_base_url": { | ||
| "description": "Sekoia base URL", | ||
| "type": "string" | ||
| }, | ||
| "frequency": { | ||
| "type": "integer", | ||
| "description": "Batch frequency in seconds", | ||
| "minimum": 1, | ||
| "default": 60 | ||
| }, | ||
| "sekoia_api_key": { | ||
| "description": "API key to use from sekoia.io", | ||
| "type": "string" | ||
| }, | ||
| "batch_size": { | ||
| "type": "integer", | ||
| "description": "Number of assets to process in one batch", | ||
| "minimum": 1, | ||
| "default": 100 | ||
| } | ||
| }, | ||
| "required": ["sekoia_api_key"], | ||
| "secrets": ["sekoia_api_key"], | ||
| "internal": ["sekoia_base_url", "sekoia_api_key", "frequency", "batch_size"] | ||
| } | ||
| } |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| from functools import cached_property | ||
|
|
||
| from requests import Response | ||
| from requests.exceptions import RequestException, Timeout | ||
| from sekoia_automation.account_validator import AccountValidator | ||
|
|
||
| from holm_security.client import ApiClient | ||
|
|
||
|
|
||
| class HolmSecurityAccountValidator(AccountValidator): | ||
| """Validate Holm Security credentials by pinging the devices endpoint. | ||
|
|
||
| A ``200 OK`` on ``GET /v2/devices?page_size=1`` confirms the token is valid. | ||
| """ | ||
|
|
||
| TIMEOUT = 30 | ||
| VALIDATION_ENDPOINT = "/v2/devices" | ||
|
|
||
| @cached_property | ||
| def base_url(self) -> str: | ||
| return str(self.module.configuration["base_url"]).rstrip("/") | ||
|
|
||
| @cached_property | ||
| def client(self) -> ApiClient: | ||
| return ApiClient(base_url=self.base_url, token=self.module.configuration["api_token"]) | ||
|
|
||
| @cached_property | ||
| def validation_url(self) -> str: | ||
| return f"{self.base_url}{self.VALIDATION_ENDPOINT}" | ||
|
|
||
| @staticmethod | ||
| def _describe_error(response: Response) -> str: | ||
| code = response.status_code | ||
|
|
||
| try: | ||
| detail = response.json() | ||
| except ValueError: | ||
| detail = response.text | ||
|
|
||
| if 400 <= code < 500: | ||
| return f"Client error ({code}) while validating Holm Security credentials: {detail}" | ||
|
|
||
| if 500 <= code < 600: | ||
| return f"Server error ({code}) while validating Holm Security credentials: {detail}" | ||
| return f"Unexpected status ({code}) while validating Holm Security credentials: {detail}" | ||
|
|
||
| def validate(self) -> bool: | ||
| self.log(message="Starting credentials validation for Holm Security asset connector", level="info") | ||
|
|
||
| try: | ||
| response = self.client.get(self.validation_url, params={"page_size": 1}, timeout=self.TIMEOUT) | ||
| except Timeout: | ||
| message = f"Timeout while validating Holm Security credentials at {self.validation_url}" | ||
| self.log(message=message, level="error") | ||
| self.error(message) | ||
|
|
||
| return False | ||
|
|
||
| except RequestException as error: | ||
| message = f"Network error while validating Holm Security credentials: {error}" | ||
| self.log(message=message, level="error") | ||
| self.error(message) | ||
|
|
||
| return False | ||
|
|
||
| except Exception as error: | ||
| message = f"Unexpected error while validating Holm Security credentials: {error}" | ||
| self.log(message=message, level="error") | ||
| self.error(message) | ||
|
|
||
| return False | ||
|
|
||
| if response.status_code == 200: | ||
| self.log(message="Holm Security credentials validated successfully", level="info") | ||
| return True | ||
|
|
||
| message = self._describe_error(response) | ||
|
|
||
| self.log(message=message, level="error") | ||
| self.error(message) | ||
|
|
||
| return False |
Empty file.
259 changes: 259 additions & 0 deletions
259
HolmSecurity/holm_security/asset_connector/device_assets.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,259 @@ | ||
| from collections.abc import Generator | ||
| from datetime import datetime | ||
| from functools import cached_property | ||
|
|
||
| from dateutil.parser import isoparse | ||
| from pydantic import ValidationError | ||
| from requests.exceptions import RequestException | ||
| from sekoia_automation.asset_connector import AssetConnector | ||
| from sekoia_automation.asset_connector.models.ocsf.base import Metadata, Product | ||
| from sekoia_automation.asset_connector.models.ocsf.device import ( | ||
| Device, | ||
| DeviceOCSFModel, | ||
| DeviceTypeId, | ||
| DeviceTypeStr, | ||
| NetworkInterface, | ||
| NetworkInterfaceTypeId, | ||
| NetworkInterfaceTypeStr, | ||
| OperatingSystem, | ||
| OSTypeId, | ||
| OSTypeStr, | ||
| ) | ||
| from sekoia_automation.storage import PersistentJSON | ||
|
|
||
| from holm_security.asset_connector.models import HolmDevice, HolmDevicePage | ||
| from holm_security.client import ApiClient | ||
|
|
||
|
|
||
| class HolmSecurityDeviceAssetConnector(AssetConnector): | ||
| """Collect agent-managed devices from Holm Security and map them to OCSF.""" | ||
|
|
||
| # API configuration | ||
| DEVICES_ENDPOINT: str = "/v2/devices" | ||
| DEFAULT_PAGE_SIZE: int = 100 | ||
| REQUEST_TIMEOUT: int = 60 | ||
|
|
||
| # Product / metadata constants | ||
| PRODUCT_NAME: str = "Holm Security" | ||
| PRODUCT_VERSION: str = "v2" | ||
| METADATA_VERSION: str = "1.5.0" | ||
|
|
||
| # OCSF Device Inventory Info constants | ||
| ACTIVITY_ID: int = 2 | ||
| ACTIVITY_NAME: str = "Collect" | ||
| CATEGORY_NAME: str = "Discovery" | ||
| CATEGORY_UID: int = 5 | ||
| CLASS_NAME: str = "Device Inventory Info" | ||
| CLASS_UID: int = 5001 | ||
| TYPE_NAME: str = "Device Inventory Info: Collect" | ||
| TYPE_UID: int = 500102 | ||
|
|
||
| # Holm os_family -> OCSF OS type mapping | ||
| OS_FAMILY_MAP: dict[str, tuple[OSTypeStr, OSTypeId]] = { | ||
| "windows": (OSTypeStr.WINDOWS, OSTypeId.WINDOWS), | ||
| "linux": (OSTypeStr.LINUX, OSTypeId.LINUX), | ||
| "macos": (OSTypeStr.MACOS, OSTypeId.MACOS), | ||
| "mac": (OSTypeStr.MACOS, OSTypeId.MACOS), | ||
| "android": (OSTypeStr.ANDROID, OSTypeId.ANDROID), | ||
| "ios": (OSTypeStr.IOS, OSTypeId.IOS), | ||
| } | ||
|
|
||
| def __init__(self, *args, **kwargs) -> None: | ||
| super().__init__(*args, **kwargs) | ||
| self.context = PersistentJSON("device_context.json", self._data_path) | ||
|
|
||
| @property | ||
| def most_recent_last_sync(self) -> str | None: | ||
| with self.context as cache: | ||
| return cache.get("most_recent_last_sync") | ||
|
|
||
| @cached_property | ||
| def base_url(self) -> str: | ||
| return str(self.module.configuration["base_url"]).rstrip("/") | ||
|
|
||
| @cached_property | ||
| def client(self) -> ApiClient: | ||
| return ApiClient(base_url=self.base_url, token=self.module.configuration["api_token"]) | ||
|
|
||
| @cached_property | ||
| def metadata(self) -> Metadata: | ||
| return Metadata( | ||
| product=Product(name=self.PRODUCT_NAME, version=self.PRODUCT_VERSION), | ||
| version=self.METADATA_VERSION, | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def _to_epoch(value: str | None) -> float | None: | ||
| """Convert an ISO 8601 timestamp to a Unix epoch float.""" | ||
| if not value: | ||
| return None | ||
| return isoparse(value).timestamp() | ||
|
|
||
| @staticmethod | ||
| def build_device_type(os_is_server: bool | None) -> tuple[DeviceTypeStr, DeviceTypeId]: | ||
| """Map ``os_is_server`` to an OCSF device type.""" | ||
| if os_is_server: | ||
| return DeviceTypeStr.SERVER, DeviceTypeId.SERVER | ||
|
|
||
| if os_is_server is False: | ||
| return DeviceTypeStr.DESKTOP, DeviceTypeId.DESKTOP | ||
|
|
||
| return DeviceTypeStr.UNKNOWN, DeviceTypeId.UNKNOWN | ||
|
|
||
| def build_operating_system(self, device: HolmDevice) -> OperatingSystem | None: | ||
| """Map the Holm OS fields to an OCSF ``OperatingSystem`` object.""" | ||
| if device.os_name is None and device.os_family is None: | ||
| return None | ||
|
|
||
| os_type: OSTypeStr = OSTypeStr.UNKNOWN | ||
| os_type_id: OSTypeId = OSTypeId.UNKNOWN | ||
| if device.os_family: | ||
| os_type, os_type_id = self.OS_FAMILY_MAP.get( | ||
| device.os_family.strip().lower(), (OSTypeStr.OTHER, OSTypeId.OTHER) | ||
| ) | ||
|
|
||
| return OperatingSystem(name=device.os_name, type=os_type, type_id=os_type_id) | ||
|
|
||
| def build_network_interfaces(self, device: HolmDevice) -> list[NetworkInterface] | None: | ||
| """Build the primary IPv4 and secondary IPv6 network interfaces.""" | ||
| network = device.network | ||
| if network is None: | ||
| return None | ||
|
|
||
| interfaces: list[NetworkInterface] = [] | ||
|
|
||
| if network.ip_address: | ||
| interfaces.append( | ||
| NetworkInterface( | ||
| ip=network.ip_address, | ||
| mac=network.mac_address, | ||
| hostname=device.hostname, | ||
| type=NetworkInterfaceTypeStr.WIRED, | ||
| type_id=NetworkInterfaceTypeId.WIRED, | ||
| ) | ||
| ) | ||
|
|
||
| if network.ip_address_v6: | ||
| interfaces.append( | ||
| NetworkInterface( | ||
| ip=network.ip_address_v6, | ||
| type=NetworkInterfaceTypeStr.WIRED, | ||
| type_id=NetworkInterfaceTypeId.WIRED, | ||
| ) | ||
| ) | ||
|
|
||
| return interfaces or None | ||
|
|
||
| def build_device(self, device: HolmDevice) -> Device: | ||
| """Map a Holm device record to an OCSF ``Device`` object.""" | ||
| device_type, device_type_id = self.build_device_type(device.os_is_server) | ||
| network = device.network | ||
|
|
||
| return Device( | ||
| type=device_type, | ||
| type_id=device_type_id, | ||
| uid=device.uid, | ||
| name=device.device_name, | ||
| hostname=device.hostname or "", | ||
| os=self.build_operating_system(device), | ||
| ip=network.ip_address if network else None, | ||
| network_interfaces=self.build_network_interfaces(device), | ||
| created_time=self._to_epoch(device.created), | ||
| last_seen_time=self._to_epoch(device.last_sync), | ||
| ) | ||
|
|
||
| def map_fields(self, device: HolmDevice) -> DeviceOCSFModel: | ||
| """Map a Holm device record to the OCSF Device Inventory Info model.""" | ||
| event_time = self._to_epoch(device.last_sync) or self._to_epoch(device.created) | ||
| if event_time is None: | ||
| raise ValueError(f"Device {device.uid} has neither last_sync nor created timestamp") | ||
|
|
||
| return DeviceOCSFModel( | ||
| activity_id=self.ACTIVITY_ID, | ||
| activity_name=self.ACTIVITY_NAME, | ||
| category_name=self.CATEGORY_NAME, | ||
| category_uid=self.CATEGORY_UID, | ||
| class_name=self.CLASS_NAME, | ||
| class_uid=self.CLASS_UID, | ||
| type_name=self.TYPE_NAME, | ||
| type_uid=self.TYPE_UID, | ||
| time=event_time, | ||
| metadata=self.metadata, | ||
| device=self.build_device(device), | ||
| ) | ||
|
|
||
| def _fetch_device_pages(self) -> Generator[HolmDevicePage, None, None]: | ||
| """Fetch device pages, following the ``next`` URL until it is null.""" | ||
| url: str | None = f"{self.base_url}{self.DEVICES_ENDPOINT}" | ||
| params: dict[str, int] | None = {"page_size": self.DEFAULT_PAGE_SIZE} | ||
|
|
||
| try: | ||
| while url and self.running: | ||
| response = self.client.get(url, params=params, timeout=self.REQUEST_TIMEOUT) | ||
| response.raise_for_status() | ||
|
|
||
| page = HolmDevicePage.model_validate(response.json()) | ||
| self.log( | ||
| message=f"Fetched {len(page.results)} devices (total {page.count})", | ||
| level="info", | ||
| ) | ||
|
|
||
| yield page | ||
|
|
||
| url = page.next | ||
| # The `next` URL already carries the pagination query parameters. | ||
| params = None | ||
| except RequestException as error: | ||
| self.log(message=f"Holm Security API request failed: {error}", level="error") | ||
| raise | ||
|
|
||
| def get_assets(self) -> Generator[DeviceOCSFModel, None, None]: | ||
| """Yield OCSF device assets, skipping devices already seen via checkpoint.""" | ||
| checkpoint = self.most_recent_last_sync | ||
| checkpoint_dt: datetime | None = isoparse(checkpoint) if checkpoint else None | ||
|
|
||
| max_last_sync_dt: datetime | None = checkpoint_dt | ||
| max_last_sync_raw: str | None = checkpoint | ||
|
|
||
| generated = 0 | ||
| skipped = 0 | ||
|
|
||
| for page in self._fetch_device_pages(): | ||
| for device in page.results: | ||
| device_dt = isoparse(device.last_sync) if device.last_sync else None | ||
|
|
||
| # Client-side checkpoint filter: skip devices not modified since last run. | ||
| if checkpoint_dt is not None and device_dt is not None and device_dt <= checkpoint_dt: | ||
| skipped += 1 | ||
| continue | ||
|
|
||
| if device_dt is not None and (max_last_sync_dt is None or device_dt > max_last_sync_dt): | ||
| max_last_sync_dt = device_dt | ||
| max_last_sync_raw = device.last_sync | ||
|
|
||
| try: | ||
| asset = self.map_fields(device) | ||
| except (ValueError, ValidationError) as error: | ||
| skipped += 1 | ||
| self.log(message=f"Skipping device {device.uid}: {error}", level="warning") | ||
| continue | ||
|
|
||
| generated += 1 | ||
| yield asset | ||
|
|
||
| # Persist the new checkpoint only after the full run has been consumed. | ||
| if max_last_sync_raw and max_last_sync_raw != checkpoint: | ||
| self._latest_time = max_last_sync_raw | ||
|
|
||
| self.log( | ||
| message=f"Asset generation complete - generated: {generated}, skipped: {skipped}", | ||
| level="info", | ||
| ) | ||
|
|
||
| def update_checkpoint(self) -> None: | ||
| if self._latest_time: | ||
| with self.context as cache: | ||
| cache["most_recent_last_sync"] = self._latest_time | ||
| self.log(message=f"Checkpoint updated to {self._latest_time}", level="debug") | ||
| else: | ||
| self.log(message="No checkpoint update needed", level="debug") | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Protect the checkpoint filter from invalid last_sync values to avoid runtime errors.
isoparse(device.last_sync)runs outside the existingtry/except, so a malformedlast_syncwill raiseValueErrorand crash before the error handling is reached. Please wrap the parse in its owntry/exceptand treat invalid timestamps asNone, e.g.:This keeps the checkpoint filter resilient to bad timestamp data.