-
Notifications
You must be signed in to change notification settings - Fork 60
akamai migration #2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mchupeau-sk
wants to merge
1
commit into
develop
Choose a base branch
from
imp/akmai-migration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
akamai migration #2888
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,28 @@ | ||
| FROM python:3.11 | ||
| FROM python:3.14 | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| RUN pip install poetry | ||
| # Install uv | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/ | ||
|
|
||
| # Install dependencies | ||
| COPY poetry.lock pyproject.toml /app/ | ||
| RUN poetry config virtualenvs.create false && poetry install --only main | ||
| COPY pyproject.toml uv.lock /app/ | ||
| RUN uv sync --frozen --no-dev --no-install-project | ||
|
|
||
| # Make the project virtual environment the default interpreter | ||
| ENV PATH="/app/.venv/bin:$PATH" | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN useradd -ms /bin/bash sekoiaio-runtime | ||
|
|
||
| # Some dependencies (e.g. pyrate-limiter, used by requests-ratelimiter) resolve a temp | ||
| # directory at import time via tempfile.gettempdir(). The default system temp directories | ||
| # (/tmp, /var/tmp, /usr/tmp) may not be writable by the non-root runtime user in the | ||
| # deployment environment, so provide a dedicated writable directory and point TMPDIR at it. | ||
| RUN mkdir -p /app/tmp && chown sekoiaio-runtime:sekoiaio-runtime /app/tmp | ||
| ENV TMPDIR=/app/tmp | ||
|
|
||
| USER sekoiaio-runtime | ||
|
|
||
| ENTRYPOINT [ "python", "./main.py" ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Module-specific mise config. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Common tools and tasks (uv, test, lint, format) are inherited from the | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # repository root mise.toml. Only the Python version and the local .venv are | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # declared here, since both are module-specific. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [tools] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| python = "3.14" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| [env] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| _.python.venv = { path = ".venv", create = false } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Clarify the generator element types for better static checking and readability.
Since you’re updating the hints, please specify the yielded types more precisely. For example,
__fetch_next_eventscould beGenerator[list[dict[str, Any]], None, None], andfetch_events/filter_processed_eventsGenerator[dict[str, Any], None, None]. This helps mypy and readers understand the data shape flowing through the connector.Suggested implementation:
) def fetch_events(self) -> Generator[dict[str, Any], None, None]: most_recent_date_seen: int = self.from_timestamp