-
-
Notifications
You must be signed in to change notification settings - Fork 356
Rework MSVC environment powershell configuration and description in CHANGES.txt and RELEASE.txt #4720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rework MSVC environment powershell configuration and description in CHANGES.txt and RELEASE.txt #4720
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
da4d268
Temporarily restore partial GH #4717 original CHANGES.txt text.
jcbrill 0797b2d
Update CHANGES.txt [skip ci]
jcbrill 23eef47
Update CHANGES.txt [skip ci]
jcbrill d5ae431
Merge branch 'master' into jbrill-msvc-slowtext
jcbrill b39e674
MSVC: Import POWERSHELL_TELEMETRY_OPTOUT, PSDisableModuleAnalysisCach…
jcbrill 025a41d
MSVC: update the powershell executable order on the msvc environment …
jcbrill f25895b
MSVC: update CHANGES.txt and RELEASE.txt.
jcbrill b5847cb
Merge branch 'master' into jbrill-msvc-slowtext
jcbrill 02133b1
Fix MSVC environment system path construction issues.
jcbrill 40b6675
Merge branch 'master' into jbrill-msvc-slowtext
jcbrill 3290ac7
Rework CHANGES.txt and RELEASE.txt per review comments.
jcbrill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a blurb about the user impact. Perhaps something like.
"In some environments (such as Github Actions) this can yield a significant reduction in the time to initialize MSVC. (Without this change you may see > 10x slowdown) "
replace ##x slowdown with your best approximation of your test results.
The idea is that anyone reading this looking for a version with a fix should know from this blurb that it is indeed fixed.
RELEASE.txt is what gets sent to the mailing lists and other notification channels. Users then would have to go to the CHANGES.txt.
So RELEASE.txt should have more or less the same content as this releases CHANGE.txt blurb, but organized differently, without the attribution.