Replace omega_h functions in Python API with PyOmega_h#330
Open
Sichao25 wants to merge 2 commits into
Open
Conversation
Collaborator
|
-908 lines of code...I'm a fan. Once this is done it closes #329 |
Collaborator
|
Is there a specific version numer of MPI that will be required for this? We should bump the minor version in CMake. We should also update the spack package (or at least open an issue there mentioning the new omega_h version requirements) |
Contributor
Author
|
Do you mean the Omega_h version? I'm not aware of this PR changing any MPI version requirements. |
Collaborator
|
Sorry I meant Omega_h...that's what 4 hours of sleep does to your brain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Omega_h has updated its python api, it is safe to remove the redundant Python bindings from PCMS. Note that this change will require the related libraries to be built as shared libraries.