Skip to content

Adding offbeam gate counting in the CAFs #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzettle wants to merge 3 commits into from
Closed

Adding offbeam gate counting in the CAFs #67

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c81f81
Implementation of offbeam gate counter in CAF similar to how BNB/NuMI…
Aug 25, 2022
ced72fc
Merge tag 'v09_14_09' into feature/jzettle_OffBeamGateCountCAFs
Sep 30, 2022
c07afa5
Addressing review comments
Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sbnobj/Common/POTAccounting/EXTCountInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ namespace sbn {
public:

int gates_since_last_trigger;
bool isBNBOffBeam;
bool isNuMIOffBeam;
bool isMajority;

@jzennamo jzennamo Oct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Majority" and "MinBias" are a bit ICARUS jargon-y, could you add a comment after each explaining what they are and/or adopting a more detector agnostic naming nomenclature?

bool isMinBias;

};
} // end namespace sbn
Expand Down
4 changes: 3 additions & 1 deletion sbnobj/Common/POTAccounting/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
<version ClassVersion="11" checksum="4062206176"/>
<version ClassVersion="10" checksum="3057205612"/>
</class>
<class name="sbn::EXTCountInfo" ClassVersion="11">

@jzennamo jzennamo Oct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @wesketchum complains when people manually change these, but I am not sure why, I defer to him

@jzettle jzettle Oct 12, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesketchum is there a procedure for this? I start at 10 and increment from there as I have seen in other examples

@wesketchum wesketchum Oct 13, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main issue is to avoid proliferation of the version numbers during development. If data hasn't been written in 'older' versions that needs to be re-read, then we can remove those versions.

So, in this case: if no one has ever made data with 'version 10' that we need to read back, then I'd advocate that we make version 11 --> 10, and 'start' from there. If that's not the case, what you've done is exactly right.

@wesketchum wesketchum Oct 13, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or, to this point, if version 12 needs to be kept or not ... if not, can replace 12 with 13, and drop line 16).

<class name="sbn::EXTCountInfo" ClassVersion="13">
<version ClassVersion="13" checksum="90106564"/>
<version ClassVersion="12" checksum="3544499454"/>
Comment on lines +14 to +16

@PetrilloAtWork PetrilloAtWork Oct 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be:

Suggested change
<class name="sbn::EXTCountInfo" ClassVersion="13">
<version ClassVersion="13" checksum="90106564"/>
<version ClassVersion="12" checksum="3544499454"/>
<class name="sbn::EXTCountInfo" ClassVersion="12">
<version ClassVersion="12" checksum="90106564"/>

Rule of thumb is that a pull request should add at most one version per class.

<version ClassVersion="11" checksum="2738807909"/>
<version ClassVersion="10" checksum="1347272"/>
</class>
Expand Down