Skip to content

Modify corrected OpFlash to include particle and photon propagation time #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asanchezcastillo wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −1
Open

Modify corrected OpFlash to include particle and photon propagation time #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8321669
Modify corrected OpFlash to include particle and photon propagation time
asanchezcastillo Jul 6, 2026
26b5b59
Merge branch 'develop' into feature/acastill_lightpropupdate
asanchezcastillo Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sbnobj/Common/Reco/CorrectedOpFlashTiming.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ namespace sbn {
float NuToFLight { fDefault }; ///< | Nu ToF using light only | (us)
float NuToFCharge { fDefault }; ///< | Nu ToF Z from tpc vertex | (us)
float OpFlashT0Corrected { fDefault }; ///< | OpFlash Time wrt RWM time after light propagation corrections | (us)
float ParticlePropagationTime { fDefault }; ///< | Average particle propagation time used to correct flash t0 | (us)
float PhotonPropagationTime { fDefault }; ///< | Average photon propagation time used to correct flash t0 | (us)
/// @}

};
Expand Down
4 changes: 3 additions & 1 deletion sbnobj/Common/Reco/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,9 @@

<class name="std::vector<geo::PlaneID>"/>

<class name="sbn::CorrectedOpFlashTiming" ClassVersion="16">
<class name="sbn::CorrectedOpFlashTiming" ClassVersion="18">
<version ClassVersion="18" checksum="1139303800"/>
<version ClassVersion="17" checksum="1139303800"/>
Comment on lines +318 to +320

@PetrilloAtWork PetrilloAtWork Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A duplicate checksum is new to me. Anyway, only one checksum update per PR:

Suggested change
<class name="sbn::CorrectedOpFlashTiming" ClassVersion="18">
<version ClassVersion="18" checksum="1139303800"/>
<version ClassVersion="17" checksum="1139303800"/>
<class name="sbn::CorrectedOpFlashTiming" ClassVersion="17">
<version ClassVersion="17" checksum="1139303800"/>

<version ClassVersion="16" checksum="1734226620"/>
<version ClassVersion="15" checksum="2401924061"/>
<version ClassVersion="14" checksum="2635318722"/>
Expand Down