Skip to content

Light Calorimetry: Add obj for light calo objects #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hgreenlee merged 15 commits into from
Apr 7, 2026
Merged

Light Calorimetry: Add obj for light calo objects #158

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d20b9a3
light calorimetry object, working version commit
lynnt20 Apr 25, 2023
e39af6a
add helper functions
lynnt20 May 16, 2023
fa0960e
Merge tag 'v09_19_00_01' into feature/lynnt_lightcalorimetry
lynnt20 May 16, 2024
878f4bd
Merge tag 'v09_19_05' into feature/lynnt_lightcalorimetry
lynnt20 Feb 12, 2025
7011f08
Merge tag 'v10_00_08' into feature/lynnt_lightcalorimetry
lynnt20 Apr 28, 2025
6d13a02
Merge tag 'v10_00_10' into feature/lynnt_lightcalorimetry
lynnt20 Apr 30, 2025
3d1aa8c
Merge tag 'v10_01_01' into feature/lynnt_lightcalorimetry
lynnt20 Aug 4, 2025
94bb6d1
Merge tag 'v10_03_00' into feature/lynnt_lightcalorimetry
lynnt20 Nov 13, 2025
e7249f6
simplify the class for light calo objects
lynnt20 Nov 17, 2025
234ce58
rename libraries, add comments
lynnt20 Dec 10, 2025
249628a
Updated CMakeLists.txt
kjplows Dec 17, 2025
baddfca
Merge branch 'release/v10_03_02_01'
kjplows Dec 17, 2025
6d4ab84
Merge tag 'v10_03_02_01' into feature/lynnt_lightcalorimetry
lynnt20 Jan 14, 2026
50391f8
add class versions/checksums, explicitly register std::pair
lynnt20 Jan 14, 2026
9f24cf3
change from `class` to `struct`, change to "plain old data" class only
lynnt20 Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sbnobj/Common/Reco/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ cet_make_library(
CNNScore.cc
CRUMBSResult.cc
FlashTriggerPrimitive.cc
LightCalo.cc
MVAPID.cc
MergedTrackInfo.cc
OpT0FinderResult.cc
Expand Down
1 change: 1 addition & 0 deletions sbnobj/Common/Reco/LightCalo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "sbnobj/Common/Reco/LightCalo.h"
47 changes: 47 additions & 0 deletions sbnobj/Common/Reco/LightCalo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
/**
* @file sbnobj/Common/Reco/LightCalo.h
* @brief Defines data structures for light calorimetry products.
* @author Lynn Tung
* @date December 2nd, 2025
*
*/

#ifndef sbnobj_LightCalo_H
#define sbnobj_LightCalo_H

#include <limits>

namespace sbn{

/**
* @brief A simple class to store reconstructed charge, light, and visible energy.
*/

class LightCalo {
public:
Comment thread
lynnt20 marked this conversation as resolved.
Outdated

@PetrilloAtWork PetrilloAtWork Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now redundant (struct members are public by default).


// NaN value to initialize data members
static constexpr double nan = std::numeric_limits<double>::signaling_NaN();

@PetrilloAtWork PetrilloAtWork Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the capitalisation NaN is so "standard" that even C++, that uses all small letters, uses it. Consider replacing nan with NaN.


/// @name Reconstructed charge, light, and visible energy data members.
/// @{
double charge = nan; ///< Total charge in a reconstructed interaction (recob::Slice) [# of electrons]
double light = nan; ///< Total light in a reconstructed interaction (recob::Slice + recob::OpFlash) [# of photons]
double energy = nan; ///< Total visible energy (sum of charge+light) for a reconstructed interaction [GeV]
int bestplane = -1; ///< Plane that was used for the total charge
/// @}

/**
* Default constructor.
*/
LightCalo() = default;
LightCalo(double charge, double light, double energy, int bestplane)
: charge(charge)
, light(light)
, energy(energy)
, bestplane(bestplane)
{}
Comment thread
lynnt20 marked this conversation as resolved.
Outdated
};
}

#endif
1 change: 1 addition & 0 deletions sbnobj/Common/Reco/classes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "sbnobj/Common/Reco/VertexHit.h"
#include "sbnobj/Common/Reco/MVAPID.h"
#include "sbnobj/Common/Reco/CRUMBSResult.h"
#include "sbnobj/Common/Reco/LightCalo.h"
#include "sbnobj/Common/Reco/OpT0FinderResult.h"
#include "sbnobj/Common/Reco/CNNScore.h"
#include "sbnobj/Common/Reco/TPCPMTBarycenterMatch.h"
Expand Down
16 changes: 16 additions & 0 deletions sbnobj/Common/Reco/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,22 @@
<class name="art::Assns<sbn::crt::CRTHit, recob::Track, void>" />
<class name="art::Wrapper<art::Assns<sbn::crt::CRTHit, recob::Track, void>>" />

<class name="sbn::LightCalo">
</class>
Comment thread
lynnt20 marked this conversation as resolved.
Outdated
<class name="std::vector<sbn::LightCalo>" />
<class name="art::Wrapper<sbn::LightCalo>" />
<class name="art::Wrapper<std::vector<sbn::LightCalo>>" />

<class name="art::Assns<recob::Slice, sbn::LightCalo>" />
<class name="art::Wrapper<art::Assns<recob::Slice, sbn::LightCalo>>" />
<class name="art::Assns<sbn::LightCalo, recob::Slice, void>" />
<class name="art::Wrapper<art::Assns<sbn::LightCalo, recob::Slice, void>>"/>

<class name="art::Assns<recob::OpFlash, sbn::LightCalo>" />
<class name="art::Assns<sbn::LightCalo, recob::OpFlash, void>" />
<class name="art::Wrapper<art::Assns<recob::OpFlash, sbn::LightCalo>>" />
<class name="art::Wrapper<art::Assns<sbn::LightCalo, recob::OpFlash, void>>" />
Comment thread
lynnt20 marked this conversation as resolved.
Outdated

<class name="sbn::OpT0Finder">
</class>
<class name="std::vector<sbn::OpT0Finder>" />
Expand Down