Skip to content

initialize some spine vars - #165

Merged
kjplows merged 4 commits into
developfrom
bugfix/spine_init
Oct 20, 2025
Merged

initialize some spine vars#165
kjplows merged 4 commits into
developfrom
bugfix/spine_init

Conversation

@nathanielerowe

@nathanielerowe nathanielerowe commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Fix a warning from CI about uninitialized variables.

@nathanielerowe nathanielerowe added the bug Something isn't working label Oct 14, 2025
justinjmueller
justinjmueller approved these changes Oct 14, 2025
View reviewed changes

@justinjmueller justinjmueller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nathanielerowe

nathanielerowe commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

trigger build

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Change ClassVersion of caf::StandardRecord to 15
72948b1 
Updated ClassVersion for caf::StandardRecord to 15.
@nathanielerowe

nathanielerowe commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

trigger build

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 15, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

kjplows
kjplows approved these changes Oct 16, 2025
View reviewed changes

@kjplows kjplows left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nathanielerowe !!

@kjplows

kjplows commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03

@kjplows kjplows moved this to Testing in SBN software development Oct 16, 2025
@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 16, 2025

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows

kjplows commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe nathanielerowe mentioned this pull request Oct 17, 2025
Closed
@kjplows

kjplows commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Oct 17, 2025

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Oct 20, 2025
@kjplows
kjplows merged commit 75f9325 into develop Oct 20, 2025
3 of 6 checks passed
@github-project-automation github-project-automation Bot moved this from To merge to Done in SBN software development Oct 20, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Oct 20, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Nov 5, 2025
@nathanielerowe
nathanielerowe deleted the bugfix/spine_init branch January 12, 2026 17:40
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_11_01 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinjmueller justinjmueller justinjmueller approved these changes
@kjplows kjplows kjplows approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

PR archaeology
Status: Done
SBN software development
Status: 2025 PRs

Milestone

v10_11_01

Development

Successfully merging this pull request may close these issues.

4 participants

@nathanielerowe @FNALbuild @kjplows @justinjmueller