Skip to content

Adding offbeam gate into the CAFs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jzettle wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Adding offbeam gate into the CAFs #89

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a669ae
Adding offbeam gate accounting to CAFAna SpectrumLoader
Sep 30, 2022
b0e4012
Merge tag 'v09_59_00' into feature/jzettle_offbeamgateaccounting
Sep 30, 2022
aa04c21
Addressing review comments
Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sbnana/CAFAna/Core/SpectrumLoader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,15 @@ namespace ana
if(!sr->hdr.ismc){
const int nbnb = sr->hdr.bnbinfo.size();
const int nnumi = sr->hdr.numiinfo.size();
if(nbnb > 0 && nnumi > 0){
std::cout << "SpectrumLoader: nonzero number of both BNB (" << nbnb
<< ") and NuMI (" << nnumi << ") triggers. I'm confused"
const int next = sr->hdr.extinfo.size();
if(nbnb > 0 && nnumi > 0 && next > 0){

@jzennamo jzennamo Oct 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this abort when all three are non-zero or just when two out of three are?

std::cout << "SpectrumLoader: nonzero number of BNB (" << nbnb
<< "), NuMI (" << nnumi << "), and EXT (" << next << ") triggers. I'm confused"
Comment on lines +191 to +193

@PetrilloAtWork PetrilloAtWork Oct 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More maintainable alternative:

Suggested change
if((nbnb > 0 && nnumi > 0) || (nbnb > 0 && next > 0) || (nnumi > 0 && next > 0)){
std::cout << "SpectrumLoader: nonzero number of 2 of 3 BNB (" << nbnb
<< "), NuMI (" << nnumi << "), and EXT (" << next << ") triggers. I'm confused"
const unsigned int nGateTypes = (nbnb > 0) + (nnumi > 0) + (next > 0);
if(nGateTypes > 1){
std::cout << "SpectrumLoader: nonzero number of " << nGateTypes << " of 3 BNB (" << nbnb
<< "), NuMI (" << nnumi << "), and EXT (" << next << ") triggers. I'm confused"

<< std::endl;
abort();
}

fNReadouts += nbnb + nnumi;
fNReadouts += nbnb + nnumi + next;
}

// This record was only kept as a receptacle for exposure information. It
Expand Down