Skip to content

chore: dedupe telemetrymap types in core services #41771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kushals256 wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −5
Open

chore: dedupe telemetrymap types in core services #41771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/core-services/src/types/ITelemetryEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
type updateCounterDataType = { settingsId: string };
type slashCommandsDataType = { command: string };
import type { TelemetryEvents, TelemetryMap } from '@rocket.chat/rest-typings';

// TODO this is duplicated from /packages/rest-typings/src/v1/statistics.ts
export type TelemetryMap = { slashCommandsStats: slashCommandsDataType; updateCounter: updateCounterDataType };
export type TelemetryEvents = keyof TelemetryMap;
export type { TelemetryEvents, TelemetryMap };

export interface ITelemetryEvent {
register: (name: TelemetryEvents, fn: () => Promise<any> | void) => void;
Expand Down