fix: Auto-populate header.stamp when header omitted (backport #1220)#1223
Merged
fix: Auto-populate header.stamp when header omitted (backport #1220)#1223
Conversation
* docs: Clarify special handling of time fields * Add tests for header and time fields population * fix: Auto-populate header.stamp when header omitted * fix: Validate header type in populate_instance function (cherry picked from commit 42ce055)
bjsowa
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
rosbridge already fills the
header.stampfield with a current time whenstampis omitted but it doesn't work in situation when client omits the entireheader. This PR fixes this issue. It also clarifies the usage of"now"string in stamp fields and adds tests that check the behavior.This is an automatic backport of pull request #1220 done by Mergify.