Hfmfview refactor

[DidierA]

Refactor of PR #1926
I added function mfc_read_tag(), which is called in dump and view.

I tested on a MFC 1k card with MAD, however I don't have data to check the vigik part (starting line 6983)

[github-actions]

You are welcome to add an entry to the CHANGELOG.md as well

[iceman1001]

its an improvement. I was thinking what if we only make a boolean param for hf mf dump --nosave and guard the "pm3_save" call ...
It would be a much simpler change, where it wouldn't demand reworking the dumping part and adding a lot of params to view command.

[DidierA]

its an improvement. I was thinking what if we only make a boolean param for hf mf dump --nosave and guard the "pm3_save" call ... It would be a much simpler change, where it wouldn't demand reworking the dumping part and adding a lot of params to view command.

Makes sense. And hf mf view could call hf mf dump --nosave when called without -f

[iceman1001]

Yeah, its a little neat trick.

[iceman1001]

Lets see,
I used your refactored function, and added the hf mf dump --ns.
Now lets see how this can be done in a nicer way

[DidierA]

Am I missing something? Just updated the firmware to latest and tried hf mf dump --ns. It shows progression about blocks read, then says Called with no save option, and returns. It does not print the card's content to screen ?

[iceman1001]

should print, shouldn't save...

[iceman1001]

ping!