fix: use standard Liquid wallet derivation - #115
Merged
Conversation
Switch the wallet descriptor from the old master-xpub m/* form to LWK's standard BIP84 Liquid singlesig descriptor so the same seed restores in Apogee and Blockstream-compatible wallets. Add a regression test for the canonical mainnet and testnet/regtest descriptor shape.
tvolk131
requested changes
Jul 1, 2026
tvolk131
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the wallet descriptor from the old master-xpub m/* form to LWK's standard BIP84 Liquid singlesig descriptor so the same seed restores in Blockstream-compatible wallets. Add a regression test for the canonical mainnet and testnet/regtest descriptor shape.
Existing wallets with funds received on the old flat
m/*path may need an explicit sweep or migration path; this change only fixes descriptor derivation going forward.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.