Repository navigation
Conversation
Rem7474
force-pushed
the
refactor/type-alert-capabilities
branch
from
September 30, 2026 19:31
60b7275 to
720529a
Compare
Rem7474
force-pushed
the
refactor/use-auto-refresh
branch
from
September 30, 2026 19:31
276d4ef to
b88dd11
Compare
About fifteen composables rebuilt the same auto-refresh scaffolding by
hand: an autoRefresh toggle, a lastUpdatedAt ref, a setInterval guarded by
the toggle, and a clearInterval on unmount (some through start/stop timer
helpers). useAutoRefresh(tick, { intervalSec, enabled?, skip? }) owns it;
`enabled` covers a parent page sharing one refresh bar, `skip` a tick that
must not run during a mutation.
Migrated: useSslCertificates, useUptimeProbes, useSSLCertificateDetail,
useUptimeProbeDetail, useProxmox, useNPM (skips while a monitoring toggle
is in flight) and useUsers (skips while a role change/delete is in
flight). The remaining pages move in follow-ups.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rem7474
force-pushed
the
refactor/use-auto-refresh
branch
from
September 30, 2026 19:37
b88dd11 to
e8e1b40
Compare
Rem7474
force-pushed
the
refactor/type-alert-capabilities
branch
from
September 30, 2026 19:37
720529a to
3af0beb
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~15 composables hand-built the same auto-refresh scaffolding (toggle ref,
lastUpdatedAt,setIntervalguarded by the toggle,clearIntervalon unmount, sometimes start/stop helpers).enabled: externally owned toggle (monitoring host detail shares one bar between the uptime and SSL sections)skip: skip a tick during a mutation that reloads on its ownMigrated (7):
useSslCertificates,useUptimeProbes,useSSLCertificateDetail,useUptimeProbeDetail,useProxmox,useNPM(skip while a monitoring toggle is in flight),useUsers(skip while a role change/delete is in flight). Intervals and behaviour unchanged.Not yet migrated (follow-ups, a few per PR):
useProxmoxGuest,useProxmoxNode,useGlobalScheduledTasks,useBot,useTraffic(two cadences),HostExposureTab,HostTimelineTab,useDashboard,AlertsView,useAuditLogs,useRunbooks.frontend/CLAUDE.mdpoints new pages at the composable.Stacked on #434.
Test plan
useAutoRefresh.spec.ts(interval ticks, toggle pause, external toggle, skip, unmount)typecheck,lint🤖 Generated with Claude Code