Add decisions section to onboarding docs.#4
Add decisions section to onboarding docs.#4brentmclark wants to merge 3 commits intoRebuild-Black-Business:masterfrom
Conversation
|
|
||
| ## Decisions | ||
|
|
||
| All decisions that have been made are captured in the [decision log](./Decisions.md). Please check there for questions that have already been raised an answered. |
|
|
||
| ### What, if anything, should we do to safeguard the public-facing data on this site? | ||
|
|
||
| The data on this site was public to begin with. Scraped from other public sites, or given to us to use publicly with consent. |
There was a problem hiding this comment.
This is a sentence fragment. Suggestion:
"We compiled public data. and we were given data with consent for public use."
Something like that? We can mention scraping if we want. IANAL, but I don't think it's that important to clarify scraping vs manual curation. (I'm also attempting to stay away from a passive voice, though that's less crucial.)
llexical
left a comment
llexical
left a comment
There was a problem hiding this comment.
Looks good, not going to stop the merge but I think there are a few decisions missing, happy to add them in once this is merged in a seperate PR.
Main ones I can think of are:
What fields are we scraping? ( Though maybe that needs adding to the main page/technical requirements document?)
How are we dealing with duplicate data?
How are we handling image uploads?
Which business categories are there, what if what I am scraping looks very different?
5 participants
Great discussions unfolded today that lead to several key decisions being made. It's important for everyone to have access to these questions and their outcomes, but it's difficult to piece them together across the various conversations. So, I added them to the onboarding docs for convenience.