feat: hyperlink the app name in the footers#497
Conversation
Changed Files
|
|
marctessier
left a comment
There was a problem hiding this comment.
I like this :-) I tried all 3 languages ... all pointing to the website when I click on it .
[@readalongs/studio-web 1.6.2](https://github.com/ReadAlongs/Studio-Web)
| <a | ||
| href="https://github.com/ReadAlongs/Studio-Web" | ||
| target="_blank" | ||
| rel="noreferrer" |
There was a problem hiding this comment.
noopener would make sense here also.
Yeah, it just came up that way, not my deliberate choice. I thought it was fine so I didn't try to patch it, do you think I should make it standard hyperlink blue? |
Yes, it needs to match the rest of the site (links in the nav) |
b24932a to
f7a7aaa
Compare
|
@sergeleger @deltork I applied your feedback at long last, please re-review. Added The link color was due to visited links having the colour with this change: I am using the standard |


PR Goal?
Marc suggested the small version label at the bottom of the page should be hyperlinked to the project. I like the idea.
So...
In the Studio-Web footer and the Web-Component settings footer,
@readalongs/studio-web version: 1.6.2and@readalongs/web-component version: 1.6.2become@readalongs/studio-web 1.6.2and@readalongs/web-component 1.6.2both hyperlinked to https://github.com/ReadAlongs/Studio-WebFixes?
The lack of a connection back from the app to the project page or source code
Feedback sought?
Are you OK with the concept?
Is https://github.com/ReadAlongs/Studio-Web the right thing to link to?
Alternatives I can think of:
Priority?
low
Tests added?
no
How to test?
In the PR preview:
Confidence?
high for the code
medium for the choice of hyperlinks
Version change?
no