feat(registry): add GPO override warning alerts and WhatIf dry-run previews#611
feat(registry): add GPO override warning alerts and WhatIf dry-run previews#611HetCreep wants to merge 3 commits into
Conversation
|
Heya, Thanks for taking the time to contribute. These 2 features seem like fine additions, although from a quick glance at the implementation they probably don't cover all features/paths. I don't have time right now to fully dive into this PR, but I will return to this ASAP. |
7a83f90 to
ec6f5c8
Compare
|
Thanks for the feedback! You are completely right. Initially, the
Other parts like optional features ( |
…tions, and Start Menu replacement
52bf014 to
70723c9
Compare
|
Heya, Thanks for the making the changes. After looking at this further I think the current GPO logic has a pretty big overhead that probably isn't worth the cost. It also potentially misses many of the policies, as they don't necessarily follow a standardised structure. Instead I propose to do a boot check if the device is domain joined, and show a warning like so: $isDomainJoined = (Get-CimInstance Win32_ComputerSystem).PartOfDomain
if ($isDomainJoined) {
Write-Warning "This machine is domain-joined. Group Policy may override changes made by Win11Debloat."
}Keeps it simple, and avoids many potential issues. As for the WhatIf feature, I still see some features that are not guarded.
I also don't necessarily like the need for $DryRun needing to be injected into these functions, especially because it can be confusing as in other places a check for $script:Params.ContainsKey("WhatIf") |
Resolves #610
Changes