Retry pytest steps in actions to handle intermittent errors#630
Open
bhazelton wants to merge 2 commits into
Open
Retry pytest steps in actions to handle intermittent errors#630bhazelton wants to merge 2 commits into
bhazelton wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 2455 2455
=========================================
Hits 2455 2455 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intermittent errors in GitHub actions have been driving us crazy, so this adds automatic retries of the steps that usually error.
There is an existing action that can be used for this, but it doesn't work with conda because there's no way to use the right shell. So I used that only on the job that uses pypi. In the conda jobs I just manually check if the step passed and re-run it if it didn't.
I also consolidated the warnings test and min_versions test into the top level testing job using matrix includes and simplified the windows os handling the same way.
update: It looks like if the first attempt fails on the weird mpi error so do the retries. Which implies that the mpi error is related to the machine or the installed versions. There are other intermittent errors, so I think this is still helpful, but it doesn't seem to fix all the issues.
Motivation and Context
Types of changes
Checklist:
For all pull requests:
Build or continuous integration change checklist: