Update performance_guidelines.rst#457
Open
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
Open
Update performance_guidelines.rst#457systems-assistant[bot] wants to merge 2 commits intodevelopfrom
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
Conversation
Add text regarding [[likely]] outcomes.
…evelop/ROCm_hip/pr-3852
github-actions
Bot
added
documentation
SwRaw
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ry) enable in CI (#457) * Temp: disable RCCL tracing * Update continuous_integration.yml * Update continuous_integration.yml * Update continuous_integration.yml * Adding option to disable rccl tracing from CMake * Update codeql.yml * Misc updates - ROCPROFILER_BUILD_RCCL -> ROCPROFILER_INTERNAL_RCCL_API_TRACE - env.EXTRA_TEMP_CMAKE_OPTIONS -> env.GLOBAL_CMAKE_OPTIONS - add (advanced) option ROCPROFILER_INTERNAL_RCCL_API_TRACE * Fix rocprofiler::sdk::get_enum_label - missing enum labels for HIP_RUNTIME_API_TABLE_STEP_VERSION > 8 * Update tests/rocprofv3/advanced-thread-trace/CMakeLists.txt - improve various aspect of cmake -- particularly echoing where attdecoder_LIBRARY was found * Use CMAKE_MESSAGE_INDENT - add prefix to cmake messages to help indicate where messages are coming from - make find_package(Python3 ...) QUIET for bindings * Fix rocprofiler::sdk::get_enum_label - handle HSA_AMD_EXT_API_TABLE_MAJOR_VERSION * Fix rocprofv3 message for att library path * Fix tests/rocprofv3/advanced-thread-trace/att_input.yml config * Fix rocprofv3 check_att_capability + soversion/version library resolution - Account for ROCPROF_ATT_LIBRARY_PATH in env in check_att_capability - Add resolve_library_path - supports resolution of library names to SOVERSION and VERSION paths * Fix python linting error (unused import) --------- Co-authored-by: Ammar ELWazir <aelwazir@amd.com> Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-sdk commit: aeb1621]
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
dayatsin-amd
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: Chris Freehill <cfreehil@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add text regarding [[likely]] outcomes.
Associated JIRA ticket number/Github issue number
What type of PR is this? (check all applicable)
What were the changes?
Add a bit of information regarding likely outcomes of conditional statements.
🔁 Imported from ROCm/hip#3852
🧑💻 Originally authored by @rocm-devops