SWDEV-524815 - Specify path to hipconfig.exe instead of hipconfig on…#421
Merged
SWDEV-524815 - Specify path to hipconfig.exe instead of hipconfig on…#421
Conversation
SwRaw
pushed a commit
that referenced
this pull request
Aug 19, 2025
… library (#421) * Remove std::regex usage from rocprofiler-sdk and common library - See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118408 - std::regex usage produces exceptions or segfaults when used when on applications compiled with dual ABI - Add code restrictions workflow - simple workflow ensuring code restrictions (such as std::regex) are not used * Update CHANGELOG * Explicitly set permissions for restrictions workflow * Fix handling of /proc/cpuinfo entries with no info - e.g. "power_management:" (colon is last character) --------- Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-sdk commit: dbb2e52]
iassiour
force-pushed
the
import/develop/ROCm_hip/pr-3856
branch
from
dece3ad to
242d519
Compare
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iassiour
force-pushed
the
import/develop/ROCm_hip/pr-3856
branch
from
242d519 to
f273c76
Compare
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gandryey
approved these changes
Sep 2, 2025
systems-assistant Bot
pushed a commit
to ROCm/hip
that referenced
this pull request
Sep 2, 2025
hipconfig on windows (#421) Co-authored-by: Ioannis Assiouras <Ioannis.Assiouras@amd.com> [rocm-systems] ROCm/rocm-systems#421 (commit 0468340)
ScottTodd
reviewed
Sep 2, 2025
Comment on lines
+100
to
+104
| if(WIN32) | ||
| set(HIPCONFIG_EXE_NAME bin/hipconfig.exe) | ||
| else() | ||
| set(HIPCONFIG_EXE_NAME bin/hipconfig) | ||
| endif() |
Member
There was a problem hiding this comment.
Prefer ${CMAKE_EXECUTABLE_SUFFIX} (https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html) over a conditional like this.
We had a patch in TheRock that solved this already: https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/rocm-systems/0007-Fix-FindHIP.cmake-search-for-hipconfig.patch
Member
There was a problem hiding this comment.
In fact, those changes were proposed on ROCm/hip#3789 back in May, but that PR was never reviewed and got lost due to force pushes and other public contribution model mismatches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
Fixes https://ontrack-internal.amd.com/browse/SWDEV-524815
What type of PR is this? (check all applicable)
What were the changes?
Add path to hipconfig.exe instead of hipconfig for ROCm version >= 6.4 in C:\opt\rocm\cmake\FindHIP.cmake
Why are these changes needed?
from HIP SDK 6.4 hipconfig.exe and hipcc.exe are used, there is no more need to append .bat extension
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks
🔁 Imported from ROCm/hip#3856
🧑💻 Originally authored by @rocm-devops