Skip to content

SWDEV-529499 - Windows: FindHIP handle hipcc/hipconfig correctly#403

Closed
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
import/develop/ROCm_hip/pr-3855
Closed

SWDEV-529499 - Windows: FindHIP handle hipcc/hipconfig correctly#403
systems-assistant[bot] wants to merge 2 commits intodevelopfrom
import/develop/ROCm_hip/pr-3855

Conversation

@systems-assistant
Copy link
Copy Markdown
Contributor


🔁 Imported from ROCm/hip#3855
🧑‍💻 Originally authored by @rocm-devops

@ammallya ammallya closed this Aug 18, 2025
@ammallya ammallya deleted the import/develop/ROCm_hip/pr-3855 branch August 18, 2025 19:23
jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025
SwRaw pushed a commit that referenced this pull request Aug 19, 2025
…-rocpd (#403)

* [rocprofv3] rocpd SQLite3 database output support

* Move counters xml and yaml to source/share/rocprofiler-sdk

- more representative of install hierarchy

* Add share/rocprofiler-sdk/rocpd SQL files

* Experimental rocprofiler-sdk SQL API

* rocprofv3 default output format is rocpd

* Fix rocpd event ids for counter collection w/o kernel dispatch

* Remove fktable entries from rocpd_tables.sql

* Fix rocpd schema path

* Fix install component for roctx python bindings

* rocprofiler-sdk-rocpd

- create include/rocprofiler-sdk-rocpd
- create rocprofiler-sdk-rocpd library, package, etc.
- default all "guid" fields to "{{guid}}" in tables
- remove "{{view_uuid}}" support (always unused)

* Migrate rocprofv3 to use rocprofiler-sdk-rocpd

* Fix missing foreign key reference

* Revert change

* Fix cmake comment

* Fix maybe-uninitialized compiler warning

* Fix maybe-uninitialized compiler warning

* Add logging to rocpd_sql_load_schema

* Improve string sanitization when inserting json strings

* Initialize rocpd logging on rocprofiler-sdk-rocpd library load

* Revert lib/output/generatePerfetto.cpp changes

* [temporary] Tweak rocprofv3-test-list-avail-trace-execute test log level

* Update get_install_path for lib/rocprofiler-sdk-rocpd/sql.cpp

- try to resolve issues on RHEL/SLES for dladdr

* Update lib/common/logging.cpp

- enable environ overrides

* dlsym for rocpd_sql_load_schema

* Make dl_info.dli_fname lexically normal

* Implement node_info alternatives if /etc/machine-id does not exist

* Misc include fixes

* SHA256 and UUIDv7 support

* Implement UUIDv7 in generateRocpd.cpp

* Support push/pop environment variables

* Minor tweak

* Fix glog segfaults when unsetting glog env

* Updated CHANGELOG

* Updates tests/pytest-packages

- rocpd_reader.py: RocpdReader

* Update tests / marker_views.sql

- add test_rocpd_data

* Update rocpd_tables.sql

- Use AUTOINCREMENT
- insert "uuid" and "guid" into rocpd_metadata

* Minor updates to generateRocpd.cpp

- don't quote GUID
- use sqlite3_open_v2
- use sqlite3_close_v2

* Update execute_raw_sql_statements_impl

- uses sqlite3_last_insert_rowid for autoincrement

* Update SQL deferred_transaction

- CI check for nullptr to connection

* Apply suggestions from code review

Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>

* Code review updates

- formatting
- replace if with switch
- remove loop for {{uuid}}

* Fix pmc_groups handling in rocprofv3

* Address code review feedback

- Include rocm_version in rocprofv3 version info
- Note `--version` option for `rocprofv3` in CHANGELOG.md
- remove commented out code

* Fix packaging dependencies

* Fix install package step of CI workflow

* Fix install package step of CI workflow

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>

[ROCm/rocprofiler-sdk commit: 7afedc6]
SwRaw pushed a commit that referenced this pull request Aug 19, 2025
systems-assistant Bot pushed a commit that referenced this pull request Aug 19, 2025
dayatsin-amd pushed a commit that referenced this pull request Apr 7, 2026
Add casting a pointer from the __private__ address space to
the __flat__ address space support for gfx1250+.

Signed-off-by: Lang Yu <lang.yu@amd.com>
dayatsin-amd pushed a commit that referenced this pull request Apr 14, 2026
Add casting a pointer from the __private__ address space to
the __flat__ address space support for gfx1250+.

Signed-off-by: Lang Yu <lang.yu@amd.com>
dayatsin-amd pushed a commit that referenced this pull request Apr 15, 2026
Add casting a pointer from the __private__ address space to
the __flat__ address space support for gfx1250+.

Signed-off-by: Lang Yu <lang.yu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants