Skip to content

SWDEV-524815 - Specify path to hipconfig.exe instead of hipconfig on… #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rocm-devops wants to merge 1 commit into from
Closed

SWDEV-524815 - Specify path to hipconfig.exe instead of hipconfig on… #3856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions cmake/FindHIP.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,14 @@ if(NOT APPLE)
# Search for HIP installation
if(NOT HIP_ROOT_DIR)
# Search in user specified path first
if(WIN32)
set(HIPCONFIG_EXE_NAME bin/hipconfig.exe)
else()
set(HIPCONFIG_EXE_NAME bin/hipconfig)
endif()
find_path(
HIP_ROOT_DIR
NAMES bin/hipconfig
NAMES ${HIPCONFIG_EXE_NAME}
PATHS
"$ENV{ROCM_PATH}"
"$ENV{ROCM_PATH}/hip"
Expand Down Expand Up @@ -150,13 +155,6 @@ if(NOT APPLE)
# Now search in default paths
find_program(HIP_HIPCONFIG_EXECUTABLE hipconfig)
endif()
if(NOT UNIX)
get_filename_component(HIPCONFIG_EXECUTABLE_EXT ${HIP_HIPCONFIG_EXECUTABLE} EXT)
if(NOT HIPCONFIG_EXECUTABLE_EXT STREQUAL ".bat")
set(HIP_HIPCONFIG_EXECUTABLE "${HIP_HIPCONFIG_EXECUTABLE}.bat")
set(HIP_HIPCC_EXECUTABLE "${HIP_HIPCC_EXECUTABLE}.bat")
endif()
endif()
mark_as_advanced(HIP_HIPCONFIG_EXECUTABLE)
mark_as_advanced(HIP_HIPCC_EXECUTABLE)

Expand Down
Loading