cleanup and clarification of unified/managed memory docs#3816
Closed
briankoco wants to merge 18 commits intodocs/developfrom
Closed
cleanup and clarification of unified/managed memory docs#3816briankoco wants to merge 18 commits intodocs/developfrom
briankoco wants to merge 18 commits intodocs/developfrom
Conversation
Add hipDeviceAttributeMaxAvailableVgprsPerThread attribute
briankoco
changed the title
Contributor
|
LGTM |
neon60
approved these changes
Jul 14, 2025
Contributor
|
@briankoco Btw, this branch should target docs/develop instead of amd-staging |
Member
Author
Done |
There is no effect on warpSize
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>
Member
Author
|
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks - I borked my attempt to rebase, so I opened up a new PR for docs/develop:
#3819
…________________________________
From: Adel Johar ***@***.***>
Sent: Tuesday, July 15, 2025 5:58 AM
To: ROCm/hip ***@***.***>
Cc: Kocoloski, Brian ***@***.***>; Mention ***@***.***>
Subject: Re: [ROCm/hip] cleanup and clarification of unified/managed memory docs (PR #3816)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
[https://avatars.githubusercontent.com/u/195464005?s=20&v=4]adeljo-amd left a comment (ROCm/hip#3816)<#3816 (comment)>
@briankoco<https://github.com/briankoco> Btw, this branch should target docs/develop instead of amd-staging
—
Reply to this email directly, view it on GitHub<#3816 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIIAJWE3Q7RS36NR2MASJD3ITGFTAVCNFSM6AAAAACBJ7UIZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZSHE3TMMRQGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
N/A
What type of PR is this? (check all applicable)
What were the changes?
hipHostRegister()managed memory table entriesWhy are these changes needed?
Some of the unified memory documentation is incorrect, and performance implications of managed memory were not sufficiently captured
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks