Skip to content

Remove the need for boost for MIOpen #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BradPepersAMD wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −17
Open

Remove the need for boost for MIOpen #4475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ml-libs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,6 @@ if(THEROCK_ENABLE_MIOPEN)
endif()

if(MSVC)
# HACK, see https://github.com/ROCm/TheRock/issues/525.
# Take the most recent few MSVC versions from
# https://github.com/boostorg/boost_install/blob/develop/BoostDetectToolset.cmake
# and pass them through to the Boost_COMPILER option below. This is messy -
# maybe we can drop the Boost dependency or write new build rules for it.
if((MSVC_VERSION GREATER 1929) AND (MSVC_VERSION LESS 1950))
set(_THEROCK_MIOPEN_OVERRIDE_BOOST_COMPILER "vc143")
elseif((MSVC_VERSION GREATER 1919) AND (MSVC_VERSION LESS 1930))
set(_THEROCK_MIOPEN_OVERRIDE_BOOST_COMPILER "vc142")
elseif((MSVC_VERSION GREATER 1909) AND (MSVC_VERSION LESS 1920))
set(_THEROCK_MIOPEN_OVERRIDE_BOOST_COMPILER "vc141")
else()
message(WARNING "Unhandled MSVC_VERSION '${MSVC_VERSION}', Boost may not configure correctly")
endif()

set(_THEROCK_MIOPEN_ENABLE_TESTING ON)
else()
set(_THEROCK_MIOPEN_ENABLE_TESTING ${THEROCK_BUILD_TESTING})
Expand All @@ -108,15 +93,13 @@ if(THEROCK_ENABLE_MIOPEN)
"-DMIOPEN_USE_COMPOSABLEKERNEL=${THEROCK_MIOPEN_USE_COMPOSABLE_KERNEL}"
-DMIOPEN_USE_MLIR=OFF # TODO: enable
-DMIOPEN_TEST_DISCRETE=OFF
-DBoost_COMPILER=${_THEROCK_MIOPEN_OVERRIDE_BOOST_COMPILER}
"-DMIOPEN_INSTALL_GPU_DATABASES=\"${THEROCK_AMDGPU_TARGETS}\""
CMAKE_INCLUDES
therock_explicit_finders.cmake
COMPILER_TOOLCHAIN
amd-hip
BUILD_DEPS
rocm-cmake
therock-boost
therock-eigen
therock-frugally-deep
therock-googletest
Expand Down
Loading