Enable rocBLAS client tests to use bundled ILP64 OpenBLAS (OpenBLAS64)#4470
Draft
tony-davis wants to merge 9 commits intomainfrom
Draft
Enable rocBLAS client tests to use bundled ILP64 OpenBLAS (OpenBLAS64)#4470tony-davis wants to merge 9 commits intomainfrom
tony-davis wants to merge 9 commits intomainfrom
Conversation
- Updated FindBLAS.cmake and FindLAPACK.cmake to support both OpenBLAS and OpenBLAS64. - Added checks for BLA_SIZEOF_INTEGER to ensure correct library is found based on integer size. - Improved error messages for missing dependencies in both BLAS and LAPACK configurations. - Adjusted CMakeLists.txt to include ILP64 reference BLAS for Windows client tests. This change ensures better compatibility and clearer error handling for users configuring BLAS and LAPACK in their projects.
- Adjusted conditional logic for Windows client tests to ensure ILP64 reference BLAS is linked correctly. - Enhanced clarity in comments regarding the use of BLA_SIZEOF_INTEGER for integer size detection. This change streamlines the build configuration for testing on Windows platforms.
…t in GitHub Actions" This reverts commit 3eecbbb.
Points the submodule at 550570f546b3808ae17163bab9c4b7c36ae17c3e (local testing). Made-with: Cursor
tony-davis
added
test_filter:full
This reverts commit 4ede1e9.
Points the submodule at 46006abab39e3c916aea2afb6fd75171a6291658. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindBLAS/FindLAPACKmodules so bundled host BLAS resolution works when either LP64 (OpenBLAS/therock-host-blas) or ILP64 (OpenBLAS64/therock-host-blas64) is provided, including clearFATAL_ERRORmessages whenBLA_SIZEOF_INTEGER=8does not match available packages.THEROCK_BUILD_TESTINGis enabled, wire rocBLAS client tests to depend ontherock-host-blas64and passROCBLAS_CLIENTS_REFERENCE_ILP64=ONso reference BLAS uses the ILP64 build.Reference: ROCM-21562
Scope note
Bundled ILP64 OpenBLAS (
therock-host-blas64) is already built bythird-party/host-blas; this change connects the shared CMake finders and rocBLAS testing to it. Other math components can consume the same package viatherock-host-blas64+ ILP64 BLAS/LAPACK options; hipBLAS already referencestherock-host-blas64onmain.Test plan