Pass --gpu-targets to artifact splitter#4464
Draft
BrianHarrisonAMD wants to merge 1 commit intomainfrom
Draft
Conversation
Pass THEROCK_AMDGPU_TARGETS to the artifact splitter so only per-arch artifacts matching the current build's GPU targets are created. This prevents later CI arch jobs from overwriting earlier jobs' per-arch artifacts with versions that lack compiled binaries. Requires rocm-systems ROCm/rocm-systems#4916 for the --gpu-targets CLI flag. The flag is silently ignored by older rocm-systems versions that don't recognize it (argparse will error, so this should land after the rocm-systems change). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Leaving as a draft until this can actually land. |
Collaborator
stellaraccident
left a comment
stellaraccident
left a comment
There was a problem hiding this comment.
Good catch. I don't think other components have had this kind of overlap/race before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THEROCK_AMDGPU_TARGETSto the artifact splitter via--gpu-targetsso only per-arch artifacts for the current build's GPU targets are createdProblem
When multiple CI arch jobs (gfx94X, gfx110X, gfx120X) build MIOpen, the splitter creates per-arch artifacts for ALL architectures found in database filenames. All jobs upload to the same flat S3 prefix, so a later arch job's
miopen_lib_gfx942.tar.zst(containing only db files) overwrites the earlier gfx94X job's version (which had both CK.sofiles AND db files).Changes
Single change in
cmake/therock_artifacts.cmake: append--gpu-targets ${THEROCK_AMDGPU_TARGETS}to the split command args, guarded by theTHEROCK_AMDGPU_TARGETS-NOTFOUNDsentinel.Merge ordering
Dependencies
--gpu-targetsCLI flag tosplit_artifacts.pyTest plan
users/bharriso/dry-run-miopen-multi-arch(which includes both this change and the rocm-systems bump)🤖 Generated with Claude Code