[math-libs] Add pre_hook workaround for hipCUB ASAN ROCMChecks failure#4456
Open
[math-libs] Add pre_hook workaround for hipCUB ASAN ROCMChecks failure#4456
Conversation
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Contributor
Author
|
Verified hipCUB ASAN build with this PR - https://github.com/ROCm/TheRock/actions/runs/24241509756 |
geomin12
requested review from
HereThereBeDragons,
marbre,
stanleytsang-amd and
umfranzw
and removed request for
geomin12
Contributor
Author
|
Upstream fix merged now - ROCm/rocm-libraries#6338. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hipCUB ASAN builds fail during configure when
BUILD_BENCHMARK=ON.#4455
Technical Details
Add
pre_hook_hipCUB.cmaketo setROCM_WARN_TOOLCHAIN_VAR OFFin the cache before ROCMChecks loads, preventingvariable_watch()from being installed. This mirrors why rocRAND is unaffected, it sets the variable before ROCMChecks in its ownDependencies.cmake.TheRock issue: #4455
Upstream fix: ROCm/rocm-libraries#6338
Test Plan
BUILD_BENCHMARK=ON