[rocprofiler-systems] Make lib artifact include versioned python<VER> folder when project is configured with a single python version#4454
Open
kcossett-amd wants to merge 1 commit intomainfrom
Conversation
…figured to only use a single python version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When testing a testing improvement PR, the python tests would fail when I configured + build TheRock locally with only a single python version being used.
The
libartifact does not include thepython<ver>/folder, but does includepython/(which is generated when multiple python versions are used during configure + build).This was most likely not caught in CI as the runs usually use multiple python versions.
Technical Details
Make
"lib/python/**" ->"lib/python*/**",inartifact-rocprofiler-systems.toml`Test Plan
Tested locally using new tests that will be introduced in a future PR.
Also built locally and checked manually that it is present in
output-linux-portable/build/dist/rocm/libTest Result
Future python tests pass.
When built locally so that only
python3.12is used, I now see that therocprofsyspackage, located within our generatedpython3.12folder is present inoutput-linux-portable/build/dist/rocm/lib.Submission Checklist