Add missing RPATH entry for rocpd* binaries in the core wheel#4446
Open
lucbruni-amd wants to merge 1 commit intomainfrom
Open
Add missing RPATH entry for rocpd* binaries in the core wheel#4446lucbruni-amd wants to merge 1 commit intomainfrom
lucbruni-amd wants to merge 1 commit intomainfrom
Conversation
marbre
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes (half of) #4424
Technical Details
Added
core.rpath_dep(core, "lib/rocm_sysdeps/lib")so that ELFs in the core wheel (likelibpyrocpd.cpython-*.so) get a patchelf RPATH entry pointing tolib/rocm_sysdeps/lib/, wherelibrocm_sysdeps_sqlite3.soand friends live.Test Plan
Build Python packages according to https://github.com/ROCm/TheRock/blob/main/docs/packaging/python_packaging.md, after building TheRock, and invoke
rocpd2pftraceto ensurelibrocm_sysdeps_sqlite3.sois located.Test Result
To observe
Submission Checklist