Skip to content

Add rocpd* console script entries#4445

Open
lucbruni-amd wants to merge 1 commit intomainfrom
users/lucbruni-amd/rocpd-console-scripts
Open

Add rocpd* console script entries#4445
lucbruni-amd wants to merge 1 commit intomainfrom
users/lucbruni-amd/rocpd-console-scripts

Conversation

@lucbruni-amd
Copy link
Copy Markdown
Contributor

@lucbruni-amd lucbruni-amd commented Apr 9, 2026

Motivation

Fixes (half of) #4424

When ROCm is installed via pip, the rocpd2pftrace tool (and other rocpd2* tools) are not accessible on PATH. They are shipped inside the rocm-sdk-core package at _rocm_sdk_core/bin/ but are missing from the console_scripts entry points in setup.py.

Technical Details

  • _cli.py: Added 5 trampoline functions (rocpd, rocpd2csv, rocpd2otf2, rocpd2pftrace, rocpd2summary) that dispatch to bin/<tool> via _exec()
  • setup.py: Added 5 console_scripts entries in the Linux block so pip creates wrapper scripts in venv/bin/ for each rocpd* tool.

Test Plan

Build Python packages according to https://github.com/ROCm/TheRock/blob/main/docs/packaging/python_packaging.md, after building TheRock, and invoke each binary

Test Result

To observe

Submission Checklist

@marbre
Copy link
Copy Markdown
Member

marbre commented Apr 10, 2026

Motivation

Fixes (half of) #4424

A few more details could go to the PR description to make this more self-contained. Cross-referencing is good but the PR description will also form the commit message and no one wants to then open a browser, copy the link and check what this should actually solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants