Open
Conversation
marbre
approved these changes
Apr 10, 2026
Member
A few more details could go to the PR description to make this more self-contained. Cross-referencing is good but the PR description will also form the commit message and no one wants to then open a browser, copy the link and check what this should actually solve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes (half of) #4424
When ROCm is installed via
pip, therocpd2pftracetool (and otherrocpd2*tools) are not accessible onPATH. They are shipped inside therocm-sdk-corepackage at_rocm_sdk_core/bin/but are missing from theconsole_scriptsentry points insetup.py.Technical Details
_cli.py: Added 5 trampoline functions (rocpd,rocpd2csv,rocpd2otf2,rocpd2pftrace,rocpd2summary) that dispatch tobin/<tool>via_exec()setup.py: Added 5console_scriptsentries in the Linux block so pip creates wrapper scripts invenv/bin/for eachrocpd*tool.Test Plan
Build Python packages according to https://github.com/ROCm/TheRock/blob/main/docs/packaging/python_packaging.md, after building TheRock, and invoke each binary
Test Result
To observe
Submission Checklist