Skip to content

Remove duplicated inputs and declare after parameter validation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loganknecht wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Remove duplicated inputs and declare after parameter validation #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions R/generateAnnotationThresholds.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@ generateAnnotationThresholds <- function(gatingSet,
archDescriptionList=archDescriptionList
)

sampleNames <- flowWorkspace::sampleNames(gatingSet)
gatingSetPData <- flowWorkspace::pData(gatingSet)

#set up the faustData directory for check-pointing/metadata storage.
.initializeFaustDataDir(
Expand All @@ -238,8 +240,8 @@ generateAnnotationThresholds <- function(gatingSet,
#and their level in the imputation hierarchy.
.constructAnalysisMap(
projectPath = projectPath,
gspData = flowWorkspace::pData(gatingSet),
sampNames = flowWorkspace::sampleNames(gatingSet),
gspData = gatingSetPData,
sampNames = sampleNames,
experimentalUnit = experimentalUnit,
imputationHierarchy = imputationHierarchy,
debugFlag = debugFlag
Expand All @@ -258,7 +260,7 @@ generateAnnotationThresholds <- function(gatingSet,
#make sure the channel bounds conform to internal requirements
#test to see if there have been changes between faust runs.
.processChannelBounds(
samplesInExp = flowWorkspace::sampleNames(gatingSet),
samplesInExp = sampleNames,
projectPath = projectPath,
channelBounds = channelBounds,
debugFlag = debugFlag
Expand Down